Repository navigation
verify: Report replayed proofs as proved obligations, not as verified - #16
Merged
Merged
Conversation
…es not check what they rest on.
…n ARCHITECTURE.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Archive replay verifies each module alone, but reported a module whose obligations hold as
Verified. A source verdict also rests on what the archive does not carry: callee and trusted contracts, spec facts, partiality, and the vacuity checks. So a replay printedVerifiedwhere the source run did not:caller, whose callee's contract failsUnresolved [reason=callee.contract]Verifiedvac, with an unsatisfiable preconditionVerified [vacuous]Verifieduses_tr, calling a trusted contractVerified [trusts=tr]Verifiedloop_star, withdecreases(*)Verified [partial]VerifiedReplay now reports such a module as
Proved obligations: caller (dependencies not checked in replay), with JSON statusproved-obligations, and neverVerified. The exit code is unchanged. Failures keep their label: postconditions are not archived either, so replay certifies a counterexample by the definitions alone.Testing:
suite/replay_dependencies.cppreplays the four cases above and fails on main. The replay checks of eight tests and of the backend fidelity gate expect the new label. Verify suite: 398 passed, 1 unsupported. Replaying the archives of the 405 Verify sources (353 archive) with main and with this branch, the only change is that 1243 proofs readproved-obligationsinstead ofverified; the 486 failures and 79 unresolved results are identical.