Skip to content

Add improved validation for package submissions/removals - #15717

Open
BrendanThompson wants to merge 19 commits into
mainfrom
better-validation
Open

BrendanThompson wants to merge 19 commits into
mainfrom
better-validation

Conversation

@BrendanThompson

Copy link
Copy Markdown
Collaborator

As part of the Swift Mentorship Program @daveverwer and I have worked towards improving the validation stage(s) for package submission/removal.

  • Provide better submitter feedback on exceptions during submission/removal failures
  • Increased validation detection scenarios
  • Ability to re-trigger CI on a package where validation has failed
  • Alignment with the uplift security posture

These changes primarily enable validation of:

  • Swift toolchain version validated against the base image (assumed good)
  • Existence of a Package.swift
  • Early dropout if incoming package exists in either packages.json or denylist.json

@daveverwer

Copy link
Copy Markdown
Member

Thanks so much for all your hard work on this @BrendanThompson!

@finestructure

Copy link
Copy Markdown
Member

Thanks for your work on this, @BrendanThompson !

As a lot of the changes are happening in the CI stage I'm wondering if there's a way to test this? Do you have a fork set up perhaps where the changes have been running or if not, would be feasible to set one up to demonstrate how it works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants