Repository navigation
Make platform compilation branches explicit - #6
Merged
Merged
Conversation
dmitriyborodko
requested review from
VladimirBorodko
and removed request for
VladimirBorodko
October 16, 2026 14:16
dmitriyborodko
marked this pull request as ready for review
October 16, 2026 14:29
dmitriyborodko
added
run-ci
VladimirBorodko
requested changes
Oct 16, 2026
VladimirBorodko
requested changes
Oct 16, 2026
dmitriyborodko
added
run-ci
VladimirBorodko
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch-all
#elsebranches could silently select Linux behavior on another platform. Make PathURL, NSValue extraction, and platform-dependent test expectations explicitly choose Apple, Linux, or Windows, with a compile-time error for unsupported targets. Linux and Windows share branches where their behavior is identical. Replace negative Apple conditions in test helpers and document the supported platforms.Unix date strategies and their tests use
anyAppleOSavailability with Swift 6.4 or newer and equivalent explicit Apple OS availability annotations with older compilers, preserving Swift 6.2.3 compatibility. This applies to both generic strategy availability and legacy strategy deprecations.Validation:
All suites exclude PerformanceTests.