Repository navigation
fix(bench): support portable setup and platform comparison guards - #399
Merged
Merged
Conversation
…ility # Conflicts: # docs/CHANGELOG.md
Haoming9527
marked this pull request as ready for review
October 24, 2026 17:02
This was referenced Oct 24, 2026
Haoming9527
dismissed
Thatgfsj’s stale review
October 25, 2026 04:36
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark setup previously described Windows-only probes as applicable on POSIX, and archived runs from different platforms could be paired without warning. Setup now uses injected platform defaults and explains the skipped PowerShell, module-path and Windows payload checks. Every sweep records platform and composed component configuration even without sealing; unevaluated rows stay unknown and configuration enablement is not presented as a readiness receipt.
Comparison refuses mismatched platform metadata with exit 2. An explicit
--allow-cross-platformdiagnostic override adds a warning that differences are not a plugin effect. Legacy unknown/unknown archives remain readable. The report and offline panel show the environment facts. The opt-in, non-blocking, model-free tools smoke now has Linux, Windows and macOS legs with separate artifacts.Fixes #295. Includes the existing #381 commits as an ancestor; merge #381 first. This PR targets main so pull-request validation runs. No model sweep or cross-platform performance conclusion is claimed.
Validation:
80f210e.28a80a6. The later commit only merges current main and preserves both changelog entries.Bilingual benchmark guidance and Unreleased changelog included.