test: re-baseline post-propagation in-air fraction after TauRunner decay fix - #103
Merged
Merged
Conversation
Print the measured fraction (and its numerator/denominator) for each spectral index before asserting, so a drift in this regression number is readable straight off a CI log instead of needing a probe branch. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…y fix icecube/TauRunner#72 (361661f, 2026-07-22) detects charged-lepton decay via PROPOSAL's has_decay flag instead of testing whether the energy fell to the rest mass. Taus decay in flight while still carrying nearly all their energy, so the old test almost never fired and TauRunner returned a surviving tau at the decay vertex. With the fix TauRunner hands back a nu_tau, so inject_neutrino_event no longer returns early at src/injection/inject.jl:265 and instead samples a vertex via force_interaction_vertex. That moves where PROPOSAL starts relative to the terrain and raises the post-propagation in-air fraction: gamma=1.0 0.200 -> 0.240 (95/395) gamma=2.0 0.197 -> 0.205 (79/386) Both measured on CI run 33823627332. The gamma=2.0 value was still inside the 0.02 tolerance but had drifted for the same reason, so both are re-baselined. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
thomwg11
marked this pull request as ready for review
September 4, 2026 01:33
kcarloni
self-requested a review
September 4, 2026 12:32
Updated baseline date and comments for tau decay detection.
kcarloni
reviewed
Sep 4, 2026
kcarloni
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing this! I changed the wording because I often feel like Claude is too wordy in describing previous errors, which only adds unnecessary confusion.
kcarloni
self-requested a review
September 4, 2026 12:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Post-propagation in-air fraction(test/test_injection_regression.jl) has been failing on every PR branch since late July:Identical to the digit across four CI runs on three branches — deterministic, not noise.
Root cause: upstream TauRunner, not TamboSim
icecube/TauRunner#72 (
361661f, 2026-07-22) replaced the charged-lepton decay test in bothSlabPropagator.jlandSphericalBodyPropagator.jl:Taus decay in flight while still carrying nearly all their energy, so the old rest-mass test almost never fired: PROPOSAL decayed the tau, but TauRunner handed back a surviving tau at the decay vertex. Upstream's own regression test records 0/5 decays before, 5/5 after.
Downstream, this flips the branch at
src/injection/inject.jl:265— TauRunner now returns a ν_τ rather than a τ, soinject_neutrino_eventno longer returns early and instead samples a vertex viaforce_interaction_vertex. That moves where PROPOSAL starts relative to the terrain, which is exactly what this test measures.Last green
mainrun was 2026-07-21, the day before the fix landed. It only bites CI becauseManifest.tomlis untracked (df53a9e) andProject.tomlpins TauRunner by URL with norev, so CI resolves upstream HEAD every run while local checkouts stay on whatever they last resolved.Changes
The new TauRunner behavior is the physically correct one, so the regression values are re-baselined against it:
γ=2.0 had drifted for the same reason and was still inside the ±0.02 tolerance; re-baselined too rather than left to fail later. Tolerance unchanged.
Also adds an
@infoline printing the measured fraction and its numerator/denominator, so the next drift is readable straight off a CI log instead of needing a probe branch.Verification
Measured on run 33823627332 (4151 pass / 1 fail — the single failure being this assertion), confirmed green on 33824911441: 4152 pass / 0 fail, both fractions reproducing exactly.
Note
TauRunner is deliberately left unpinned, per discussion. Anyone with a stale local
Manifest.tomlshouldPkg.update("TauRunner")(in the repo and inexamples/) — on the pre-fix tree the old 0.200 baseline is what reproduces.🤖 Generated with Claude Code