Repository navigation
Back and Next scroll away below a long step - #230
Merged
Merged
Conversation
A long step, such as storeys and occupancy with many storeys, pushed Back, Done and Next below the panel, so finishing a step meant scrolling to its end. They now stick to the bottom of the panel, as the step bar sticks below the tabs, and the step's content scrolls between the two. Opening a step scrolled it into view with scrollIntoView, which also scrolls every scrolling container above it. Inside a host page that scrolls, that moved the page and took the tabs and step bar out of view. Only the panel holding the step scrolls now (scrollPanelTo), bringing the section to just below the sticky bars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scrollPanelTo), bringing the section to just below the sticky bars.feat/step-done; merge that first.Closes #226
User stories
Checks
npm run typecheckclean;npm test377 passing.UI before and after
Flat-roof fixture, Basic mode.