Repository navigation
test: pin that overlapping imports store each building once - #214
Merged
Merged
Conversation
Regions are unlocked by running the pipeline for one bbox after another into the same country database, and providers' tiles share buildings along their edges. Nothing tested that a building imported twice, through overlapping bboxes or a second file holding it, is stored once. TestRunForRegion_RealCitydbTool_OverlapsImportOnce runs RunForRegion against real citydb-tool on one Deggendorf tile: a western bbox, an overlapping eastern one, then the whole tile after a copy of the tile is added to the dataset folder. After each run no object id appears twice in lod2.feature or city2tabula.lod2_building; the eastern run adds buildings and the run after the copy changes no count. With citydb-tool's --import-mode=import_all in place of skip, the overlapping run fails, as feature extraction cannot process the repeated buildings.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regions are unlocked by running the pipeline for one bbox after another into the same country database, and neighbouring tiles share buildings along their edges. Nothing tested that a building imported twice is stored once.
Change
TestRunForRegion_RealCitydbTool_OverlapsImportOnce(integration, real citydb-tool, one Deggendorf tile) runsRunForRegion:After each run no object id appears twice in
lod2.featureorcity2tabula.lod2_building. The eastern run adds buildings, and the run after the copy changes no count.Tests
CITYDB_TOOL_PATHset; skipped without it, like the existing real-tool test).--import-mode=import_allin place ofskipininternal/importer/citydb.go, it fails:overlapping east bbox: RunForRegion: failed to extract features for germany: 1 job(s) failed. Repeated buildings break feature extraction, so skip mode is what keeps overlapping runs working.