Repository navigation
Read purse and inventories from the v2 Hypixel profile layout - #23
Merged
Merged
Conversation
…ile layout Hypixel's v2 profile payload keeps the coin purse under members.<uuid>.currencies and the inventories under members.<uuid>.inventory. The player and finance services still read the legacy member-root fields, so every player reported purse, armor and equipment as unavailable and the finance known total was never computed. Both helpers now prefer the v2 layout and fall back to the legacy keys. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_coin_pursereadsmembers.<uuid>.currencies.coin_purse(v2 profile layout) and falls back to the legacy member-rootcoin_purse_inventorylooks undermembers.<uuid>.inventoryfirst, then at the member root/api/v1/playersno longer reportspurse,armor,equipmentas unavailable for every player, and/api/v1/player-financecan computeknownTotalagain (MarketGuard's Player HUD showedBank + purse: n/aand no net worth because of this)Test plan
python -m pytest -q— 130 passed; profile fixture switched to the v2 layout, new unit test covers v2 + legacy for both helpersQUERY /api/v1/playersfor a player with the SkyBlock API enabled returns a numericprofile.wealth.purseand non-emptyarmor🤖 Generated with Claude Code