Repository navigation
fix(terminal): authenticate mobile WebSockets with JWT subprotocol - #77
Merged
LukeGus merged 2 commits intoSep 30, 2026
Merged
Conversation
LukeGus
added a commit
that referenced
this pull request
Oct 1, 2026
* fix: restore format checks for bundled guacamole assets (#76) * fix: respect configured rdp resolution on mobile (#75) * fix: send terminal jwt as websocket subprotocol (#77) * fix: fit vnc framebuffer and keep touch coords in sync (#74) * chore: increment ver * feat: support the 2.9 plugin api alongside older servers * fix: handle totp and browser sign-in replies for files and docker * fix: host form keeps fields it does not edit * fix: raise pod deployment targets so ios builds on newer xcode * fix: pass target triple to app intents metadata step for xcode 27 * chore: rename ipados build to ios and drop duplicate workflow * fix: restore ios dev ota workflow and move unsigned build to build-ios.yml * fix: add touch text selection and copy bar to terminal * fix: add selection handles and stop text jumping while selecting --------- Co-authored-by: ZacharyZcR <zacharyzcr1984@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH terminals on Mobile 1.5.0 keep reconnecting against Termix 2.8 because they send the JWT only in
?token=, which the server's WebSocket token extractor no longer accepts.Send the existing JWT in the
termix.jwt.*WebSocket subprotocol from both NativeWebSocketManager and the shared terminal socket factory. Retain the protocol list for automatic reconnects. The existing URL token remains for compatibility with older servers such as 2.7.1.Fixes Termix-SSH/Support#1334
Validation:
release-2.8.0-tag: query-only control is rejected with 1008, the new client is accepted; the 2.7 query-token path remains accepted.Includes the independent formatting baseline commit from #76 so the existing bundled Guacamole asset parsing failure does not block this PR's CI.
No physical iPhone/iPad SSH session or app-store build was exercised. This fixes the 2.8 authentication regression; migration to the separate 2.9 plugin WebSocket routes is outside this change. Mobile upstream currently has no dev branch, so the PR targets main.
Full CI passed for head
df6b5f3c97517667ad0eaf433a588fd72465008c, including formatting, lint, TypeScript, terminal WebSocket auth regressions and Expo config validation. CI run.