fix(rdp): prompt for session credentials on mobile - #79
Open
ZacharyZcR wants to merge 1 commit into
Open
ZacharyZcR wants to merge 1 commit into
ZacharyZcR wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to Termix-SSH/Support#1372.
Mobile requests an RDP token immediately, even when the host requires credentials at connection time. Unlike the web client, it has no prompt and cannot send promptedUsername, promptedPassword, or promptedDomain, so those hosts reach the backend with empty login credentials.
Add an RDP sign-in dialog before requesting a token. Read legacy 2.8 authentication fields and 2.9 protocolAuth summaries; hosts using saved credentials or a personal credential override continue connecting automatically. Pass temporary credentials through the existing compatibility route. Canceling does not request a token, reconnecting prompts again, and the password input is cleared on submission or cancellation. No host credentials are saved.
Validation:
No iOS device or live RDP server was available for end-to-end validation. This fixes a confirmed missing mobile flow; the reporter's authentication mode and guacd logs are still needed to establish whether it explains Support#1372, so this PR does not close that issue.