Skip to content

DBT-414 add integration tests to dbt - #319

Open
maria-tn wants to merge 19 commits into
mainfrom
DBT-414-add-integration-tests-to-dbt
Open

maria-tn wants to merge 19 commits into
mainfrom
DBT-414-add-integration-tests-to-dbt

Conversation

@maria-tn

Copy link
Copy Markdown
Contributor

@yagee-de yagee-de left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check for new-line at the end of each text file

Comment on lines +259 to +260
MCR.XEditor.Validation.Marker.error=mcr-invalid
# check why it was is-invalid

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Override
public void checkCurrentUser(String user){
driver.waitAndFindElement(USER_PROFILE_TOGGLE);
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameter user is not used

Comment on lines +9 to +11
String baseURL;

MCRWebdriverWrapper driver;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are also in MIRUserController with protected visibility

}


public void logOff() {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Override

assertEqualsIgnoreCase("Anmelden", driver.waitAndFindElement(By.id("loginURL")).getText());
}

public boolean isLoggedIn() {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Override

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed

import org.junit.Assert;
import org.mycore.common.selenium.drivers.MCRWebdriverWrapper;
import org.mycore.mir.it.controller.MIRModsEditorController;
import org.openqa.selenium.*;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeStyle: no *import

<modsContainer inherited="0">
<mods:mods xmlns:mods="http://www.loc.gov/mods/v3">
<mods:typeOfResource>text</mods:typeOfResource>
<mods:genre type="intern" authorityURI="https://www.openagrar.de/classifications/genres" valueURI="https://www.openagrar.de/classifications/genres#article"/>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix URI

driver.waitAndFindElement(By.xpath(".//button[starts-with(@name,'_xed_submit_servlet:')]")).click();
driver.waitFor(ExpectedConditions.or(
ExpectedConditions.urlMatches(".*/rc/\\d+(\\.\\d+)+.*"),
ExpectedConditions.presenceOfElementLocated( By.xpath(".//div[contains(@class,'alert-danger')]")),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codestyle before By.xpath?

@yagee-de yagee-de changed the title Dbt 414 add integration tests to dbt DBT-414 add integration tests to dbt Oct 5, 2026
@maria-tn

maria-tn commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

depends on MIR-1688

@yagee-de
yagee-de force-pushed the DBT-414-add-integration-tests-to-dbt branch from 73864df to 312f497 Compare October 9, 2026 09:39
@maria-tn
maria-tn requested a review from yagee-de October 13, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants