Skip to content

Add valid test on BoundingBox + unit test #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LabordePierre merged 1 commit into from
Dec 2, 2025
Merged

Add valid test on BoundingBox + unit test #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/GeoTools-Tests/GeoToolsBoundingBoxTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,21 @@ GeoToolsBoundingBoxTest >> testCenterAbsoluteCoordinates [
self assert: boundingBox centerAbsoluteCoordinates longitudeInDegrees equals: 0.
]

{ #category : #tests }
GeoToolsBoundingBoxTest >> testIsValid [

self deny: boundingBox isValid.

self setUpZeroBox.
self assert: boundingBox isValid.

self setUpSmallBox.
self assert: boundingBox isValid.

self setUpTopRightSmallBox.
self assert: boundingBox isValid
]

{ #category : #tests }
GeoToolsBoundingBoxTest >> testLeftLongitudeInDegrees [

Expand Down
9 changes: 9 additions & 0 deletions src/GeoTools/TGeoToolsBoundingBox.trait.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,15 @@ TGeoToolsBoundingBox >> centerAbsoluteCoordinates [
longitudeInDegrees: longitude
]

{ #category : #testing }
TGeoToolsBoundingBox >> isValid [

^ (self topLeftAbsoluteCoordinates notNil and: [
self topLeftAbsoluteCoordinates isValid ]) and: [
self bottomRightAbsoluteCoordinates notNil and: [
self bottomRightAbsoluteCoordinates isValid ] ]
]

{ #category : #accessing }
TGeoToolsBoundingBox >> leftLongitudeInDegrees [

Expand Down