Repository navigation
Visual check: main's baseline catches up, and New Session keeps room for the first message (#368) - #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A full visual probe of main (all 80 screens, all six Windows variants, in the test VM) after #375. It found the visual changes since v0.2.0 that no VM probe had reviewed, chiefly #374, which was made on a PC without Hyper-V, and baselines that earlier PRs had only refreshed in light-100 and hc-aquatic-100. Two independent reviews went through every changed and new picture, and this PR fixes the defects they found and brings the whole baseline up to date.
Fixed
test_new_codex_session_keeps_four_lines_of_first_message_on_a_short_screen, which fails on main (First message 8 pixels) and passes here.test_codex_rule_guard.py.Both are in unreleased work (#374), so there's no release-notes entry.
What the pictures showed (no
problemsin any manifest; 0 FAIL after the fix)Contrast was measured from the pixels: light text 18.4:1 to 21:1, selected rows 4.53:1; Aquatic 16.3:1, selected rows 7.89:1; Desert 10.4:1 to 15.7:1, selected rows 7.0:1. High Contrast follows the system colours throughout. After this PR the full run compares as 464 unchanged and 0 new; the only differences are the 16 New Session pictures, which this PR replaces from the run after the fix.
Full suite in the VM: 2880 passed, 7 skipped. One unrelated test (
test_refused_new_codex_chat_while_a_desktop_chat_is_open_copies_the_first_message) failed once and passed on rerun.testing/visual/descriptions.mdis rewritten for every changed surface, with the stale "local 200% capture" and "Pending #226" notes replaced.Cites #155, #368, #374.
🤖 Generated with Claude Code