Skip to content

Visual check: main's baseline catches up, and New Session keeps room for the first message (#368) - #377

Merged
kellylford merged 2 commits into
mainfrom
visual/main-catch-up
Oct 25, 2026
Merged

kellylford merged 2 commits into
mainfrom
visual/main-catch-up

Conversation

@kellylford

Copy link
Copy Markdown
Collaborator

A full visual probe of main (all 80 screens, all six Windows variants, in the test VM) after #375. It found the visual changes since v0.2.0 that no VM probe had reviewed, chiefly #374, which was made on a PC without Hyper-V, and baselines that earlier PRs had only refreshed in light-100 and hc-aquatic-100. Two independent reviews went through every changed and new picture, and this PR fixes the defects they found and brings the whole baseline up to date.

Fixed

  • New Session with Codex at 175%: Codex chats can use automatic approval review (#358) #374's longer About permissions note left First message one line tall (51 pixels), because the dialog was already as tall as the screen allows. First message now keeps four lines. The dialog grows into spare screen height before it's shown (at 100%: 620 to 635 tall, First message 57 to 72). Past that, the note gives up height, keeping at least three lines, and scrolls. At 175% the note is 171 and First message 141, with Start and Cancel in view. The other New Session screens are unchanged. Test: test_new_codex_session_keeps_four_lines_of_first_message_on_a_short_screen, which fails on main (First message 8 pixels) and passes here.
  • A double space in Codex's permissions note: with no saved rule files, "in effect: 0." was followed by two spaces. Test in test_codex_rule_guard.py.

Both are in unreleased work (#374), so there's no release-notes entry.

What the pictures showed (no problems in any manifest; 0 FAIL after the fix)

Contrast was measured from the pixels: light text 18.4:1 to 21:1, selected rows 4.53:1; Aquatic 16.3:1, selected rows 7.89:1; Desert 10.4:1 to 15.7:1, selected rows 7.0:1. High Contrast follows the system colours throughout. After this PR the full run compares as 464 unchanged and 0 new; the only differences are the 16 New Session pictures, which this PR replaces from the run after the fix.

Full suite in the VM: 2880 passed, 7 skipped. One unrelated test (test_refused_new_codex_chat_while_a_desktop_chat_is_open_copies_the_first_message) failed once and passed on rerun.

testing/visual/descriptions.md is rewritten for every changed surface, with the stale "local 200% capture" and "Pending #226" notes replaced.

Cites #155, #368, #374.

🤖 Generated with Claude Code

kellylford and others added 2 commits October 25, 2026 15:56
…ermissions note, and the visual baseline catches up with main (#368)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… when it grows, and First message yields before the buttons (#368)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kellylford
kellylford enabled auto-merge (squash) October 25, 2026 21:12
@kellylford
kellylford merged commit 3a59cab into main Oct 25, 2026
7 checks passed
@kellylford
kellylford deleted the visual/main-catch-up branch October 25, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant