Repository navigation
ci: harden workflows and add zizmor and gitleaks scans - #54
Merged
Merged
Conversation
Bring the workflows up to the handbells-used-chart-dorico-plugin baseline: - Grant no token permissions at the top of each workflow and give every job only what it uses. - Stop checkout from persisting the token in .git/config, which matters more on the self-hosted runners. - Have CodeQL analyze the workflows (the actions language) as well as the TypeScript. - Add a Repo Scan job: zizmor audits the workflows and gitleaks reads the whole history. Both are pinned release downloads checked against their SHA-256, fail the job on any finding, and upload SARIF to code scanning. - Renovate: pin action digests through the helper preset, hold every update for 7 days except security fixes, commit through the platform so its commits stay signed, and track the two scanners' version and hash.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Moving it to /language:javascript-typescript left main's configuration without a match on pull requests, so code scanning could not tell which alerts a pull request introduced and the code-scanning rule blocked the merge. It would also have dropped the dismissal on alert #1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the workflows up to the baseline already running on handbells-used-chart-dorico-plugin, so that only a change that passes CI can reach
main. The matching repository settings and rulesets are already applied (listed below), so this is the first PR to run under them. Phase E4 ofbf-wivr, tracked inbf-phhj.Changes
actionslanguage alongsidejavascript-typescript, so the workflow files themselves are scanned. The check names becomeAnalyze (actions)andAnalyze (javascript-typescript).persist-credentials: falseto every checkout, so the token is not left in.git/configon the self-hosted runners.codecov-actionpin comments from# v7to# v7.0.0, the tag that SHA points to.helpers:pinGitHubActionDigests; a 7-day minimum release age for every update except security fixes (dev dependencies were 3 days);platformCommit: enabledso its commits are signed underrequired_signatures; and a regex manager that moves each scanner'sVERSIONandSHA256together.Repository settings applied through the API alongside this PR (not in the diff):
mainruleset: no bypass actors, 0 required approvals and no code-owner requirement, review threads must be resolved, a CodeQL code-scanning rule (security alerts high or higher, and errors), and every required check pinned to the app that posts it. AddsRepo Scan,codecov/patchand the two per-language Analyze checks.release tagsruleset:v*tags cannot be deleted, force-pushed or moved.The TypeScript analysis keeps the code-scanning category it used before the matrix (
.github/workflows/codeql.yml:analyze). On a new category, code scanning could not compare a pull request against main, so the code-scanning rule blocked the merge, and dismissed alert #1 would have lost its dismissal.Why
actionsCodeQL queries look for those problems.Test Plan
renovate-config-validator --strictpassesTo see the new gate:
mainwith an empty bypass list andrelease tagstargetingrefs/tags/v*.Review Checklist