Skip to content

feat(discipline): add countdown ignition evaluator - #636

Merged
TheVicky1 merged 1 commit into
TheVicky1:mainfrom
xhbxx:feat/countdown-ignition-evaluator
Oct 20, 2026
Merged

TheVicky1 merged 1 commit into
TheVicky1:mainfrom
xhbxx:feat/countdown-ignition-evaluator

Conversation

@xhbxx

@xhbxx xhbxx commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

🏛️ PACT Pull Request

1. Related Issue

Closes #582


2. Summary of Changes

  • Add evaluateIgnitionCountdown in src/lib/discipline/countdown-ignition.ts.
  • Return countdown, action-window, and expired states from elapsed milliseconds.
  • Expose remaining whole seconds and countdown progress. This PR does not connect the evaluator to a UI.

5. Testing & Local Validation

  • npm test — run and check this box only if it passes

Validation result: pending. Update this line after running npm test.


9. Contributor Quality Checklist

  • 🌱 Micro-Contribution Fast-Path: Single-file change, pending local test verification.
  • My PR has a single, focused scope.
  • I have read and followed PACT's Contributing Guide.
  • I confirm that no secrets, API keys, private tokens, or .env.local files are included in this PR.
  • My branch was created from the latest upstream/main.
  • My commit follows the Conventional Commits format.
  • I have linked the target issue in Section 1.
  • I have reviewed my own diff for stray files.

@xhbxx
xhbxx requested a review from TheVicky1 as a code owner October 20, 2026 14:08
@vercel

vercel Bot commented Oct 20, 2026

Copy link
Copy Markdown

@xhbxx is attempting to deploy a commit to the Vicky's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

👋 Welcome to PACT OS, @xhbxx! 🚀

Thank you for taking the time to open your first pull request on PACT! We are thrilled to have you here in our open-source community.


🔍 What Happens Next?

  1. Automated Verification: Our Continuous Integration (CI) workflow is currently verifying:
    • 🔒 Zero-Secret Security Scan
    • 🔗 Markdown Link Integrity
    • 🧹 ESLint Code Quality
    • 🏷️ TypeScript Strict Typecheck
    • 🧪 56-Suite Automated Domain & Security Test Matrix
    • 🏗️ Next.js Production Build
  2. Maintainer Review: A maintainer (@TheVicky1) will review your pull request shortly.
  3. Friendly Iteration: If any adjustments or feedback are needed, we will provide clear, actionable suggestions to help get your PR merged smoothly.

📚 Helpful Quick Links

Thank you for helping make PACT better! Plan. Track. Improve. Repeat. 🏛️✨

@TheVicky1
TheVicky1 merged commit 6bcc5d5 into TheVicky1:main Oct 20, 2026
3 of 4 checks passed
@xhbxx
xhbxx deleted the feat/countdown-ignition-evaluator branch October 22, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Discipline] Add 5-Second Rule Countdown Ignition State Evaluator in src/lib/discipline/countdown-ignition.ts

2 participants