Repository navigation
Bind SDK authentication feedback to the actual resource profile - #2399
Merged
zy95-12 merged 1 commit intoNov 4, 2026
Conversation
Fix ThinkFlowLab#2398 on the delivery branch. Preserve typed SDK authentication failures and existing authRequired semantics, bind readiness and setup to stable profiles, and use the resource SDK CLI for login without copying credentials or changing Task-role context.
zy95-12
marked this pull request as ready for review
November 4, 2026 13:34
zy95-12
merged commit Nov 4, 2026
5382e13
into
ThinkFlowLab:delivery/ai-centric-development-service
11 of 13 checks passed
This was referenced Nov 4, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Codex
Fixes #2398 on
delivery/ai-centric-development-service.A container could use a different Codex login cache while readiness still appeared reusable, and refresh-token failures were reduced to generic SDK errors. Bind existing setup/probe/worker readiness to the actual persistent profile, preserve safe authentication codes through the SDK worker into
authRequired, and expose actual setup paths only to resource administrators. Configuration terminals resolve the resource SDK CLI so login uses the right program and CODEX_HOME.No credential copies, OAuth broker, new recovery routing, sandbox changes or Task-role Session resets. Changed/legacy unbound readiness requires the existing check; candidates and Review evidence remain intact. Includes memory, architecture, README/operations, OpenAPI, regression tests and generated patches.
Validation at
55f8975c3d93f27ef242a6c9d859c7b0d68986eb:npm run verifypasses: 4,938 tests, zero failures; lint, generated patch consistency and OpenAPI validation also pass.The live container login remains untouched. Expired/reused OAuth credentials still need a native login in the selected persistent profile after rollout; source merge does not perform login or deployment. Root policy budget and existing Session paths remain unchanged.
Pairing self-review covers correctness/security/conventions with no unresolved implementation blockers. Use the Owner-authorized basic CI / delivery-only merge scope; no independent forge PASS is fabricated.