Repository navigation
Separate scoped Attempt acceptance from Task completion and let Chief select the next delivery - #2537
Merged
zy95-12 merged 8 commits intoNov 5, 2026
Conversation
Expose scoped delivery facts and preserve Chief choice. Reuse durable acceptance, existing inspection and task.run continuation for a fresh next delivery without inheriting merged PR bindings. Keep Personal Agent assistance a model-chosen last resort. Fixes ThinkFlowLab#2526.
zy95-12
marked this pull request as ready for review
November 5, 2026 14:06
zy95-12
merged commit Nov 5, 2026
a809a7a
into
ThinkFlowLab:delivery/ai-centric-development-service
15 of 19 checks passed
This was referenced Nov 5, 2026
Closed
zy95-12
added a commit
that referenced
this pull request
Nov 5, 2026
Written-by: Codex Fixes #2526 (follow-up to #2537). Target: `delivery/ai-centric-development-service`. After Chief revised a Task to rev3/rev4, its already merged rev2 Attempt could never be accepted: both the advisory precheck and execution applied whole-Task requirement equality. Scoped acceptance now judges the pinned Attempt definition and its exact code/test/Review/provider-merge evidence while leaving the Task open. Settlement records both original and current revisions; an explicitly chosen next Attempt uses the current requirements. Historical parent settlement also looks up the original durable child admission using the pinned parent revision; child evidence and the committed admission remain mandatory. Whole-Task closure retains its independent current-goal checks. Chief/TaskView receive the same bounded comparison: revisions, changed fields, prior values, and the existing paged requirement source. Changes after a Chief snapshot use existing stale-snapshot correction. Prior refusal messages describe past outcomes, not current action legality. Candidate evidence, identity, permissions, execution generations, exits, pending writes and replay/rollback guards remain strict. No new workflow, timer, store, migration or automatic human escalation. Validation: - Fresh base `056cb557`: the corrected persisted-Task fixture fails the real Git/Runtime rev2→rev4 settlement/next-delivery path, actual Chief loop and advisory projection on the old requirement-equality guard; all three pass after the fix. - Final-head related suites: **281 passed / 0 failed**; the final actual Chief loop also passes with four historical same-fact refusal records. It sees legal scoped acceptance, accepts rev2, keeps Task open and explicitly starts rev4. New stale-judgement regression returns correction without blocking the Task or consulting a human. - Preserved negative coverage for mutated candidate/evidence, provider/rights/exit failures, changed requirements during I/O and incomplete whole-Task acceptance. Role budget **6/0**, API/OpenAPI **10/0**. Self-review also reproduced and repaired the child-admission revision barrier; targeted parent/evolution/Chief/negative admission regressions: **5/0**. **Final-head full root verification: 5167 passed / 0 failed**, including **8 actual DSH runtime checks**. [GitHub Test 42053449199](https://github.com/ThinkFlowLab/FlyBot/actions/runs/42053449199), attempt1: final-head Node24 / tests-ok both success. - Measured broad coverage (whole modules): shared helper **100% lines / 99.25% branches / 100% functions**; Chief 96.96/85.56/80.18; Delivery 96.91/79.74/86.67. This is not a 100% added-branch claim; unexecuted helper ranges include queue.reason null fallback, direct missing-candidate shortcircuit, and the new advisory prior-value empty-string fallback. The latter cannot authorize an action and the original full requirement remains queryable. No added source line appears in the Node uncovered-line list; that is not proof of every added branch combination. No exclusions or weakened evidence assertions. - Updated compact long-term memory, delivery/Chief/backend architecture, API/OpenAPI, decision, changelog and canonical mirrors. Original context cap/source list unchanged. Broader mandatory-context slimming stays separately deferred. - Pairing self-review covered correctness, security and conventions; no independent Verifier PASS claimed. Final source: `1f8cff3abcaad9ccf91ebb0a7b0980c4307deae0`. Not run: live OpenToday deployment/restart/state or binding edits, external provider writes, paid model inference, or a real vendor SDK/model on this new evolution path. Runtime/SDK-protocol subprocess fixtures do not establish onsite acceptance. Source preserves #2527 Feishu integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Codex
Fixes #2526. Target:
delivery/ai-centric-development-service.A merged PR no longer forces completion of its whole Task. Chief can explicitly accept the current Attempt with completed scope, evidence and remaining work. The committed receipt requests a fresh Chief judgement; Chief may then choose a new Attempt from the verified current target SHA containing the accepted merge, preserving Task-role context and old PR history while allocating a new publication identity. Whole-Task closure retains the existing criteria, dependency and input gates.
The actual Chief job receives scoped legal prechecks at
projectFacts.tasks[].repositoryRecovery.nextActionsandcontinuationOptions. Public TaskView.nextActions remains the caller's service-command list; TaskView.deliveryChoices projects the same decision prechecks. A board listing only chief.inspect does not limit Chief to inspection. Stale facts require a reread, and a rejected rework never authorizes clearing publicationBinding. Host facts/preconditions can suggest legal choices; Chief selects the action. Personal Agent → human remains the last resort chosen by Chief.Repeated Chief refusals under the same delivery scope reuse the existing configurable no-progress threshold and task-attention warning path. Summaries disclose at most five exact current failed actions. Changed facts or resolved reasons retire the old warning, so current legal choices do not conflict with historical refusals. No new timer, counter store, planner, fixed role sequence or automatic human escalation.
Current authority, snapshot, candidate/test/independent Review/provider merge, exit and external-write guards remain in force. Save failure rolls back provisional acceptance; original Effects/scheduler/quotas/request receipts provide replay, restart and failed-admission handling. Updated memory, architecture, API/OpenAPI, decision, changelog and canonical mirrors; original context budget retained.
Validation (current head
c0fcf9d7a916921f0b932b8140098dd34feceaaa):Provenance/limits: real Git, actual Runtime/Store restart and OS SDK-protocol subprocess fixtures demonstrate two Dev→Tester→Reviewer deliveries and distinct PR identities; these are deterministic fixtures, not vendor-model/onsite acceptance. Owner explicitly deferred broader mandatory-context-package cleanup to separate work. No live OpenToday mutation, deploy/restart, external provider writes or paid inference. Approved exact target Git objects must be provisioned; missing objects expose scoped repository/branch/SHAs rather than arbitrary fetch or host-HEAD fallback.