[Birfy]

Summary

Closes #809. Sync and async stop pretending to be one evolve(asynchronous=) mode.

• evolve(asynchronous=True) is a deprecated bridge (FutureWarning) to async_evolve.
• Fails closed without explicit max_seconds and max_rollouts (no invented 20s budget, no rounds×n_workers reinterpretation).
• One shared _POLICY_DRIVER_SUPPORT table; test fails if sync/async wiring drifts (executor sync-only).
• Spec plan derives max_rollouts from rounds*n_workers when missing (named at plan time, not silently at evolve).
• Docs (async.md, evolution.md) and callers updated; BudgetSettings works on both drivers (evolve: finish Policies consolidation — 57 top-level kwargs past the documented 35 budget #804).

Stacked on #816 (merge #816 first, then retarget this PR to main).

Test plan

• pytest -q tests/test_sync_async_contracts.py tests/test_provider_and_split_contracts.py tests/test_async_early_stop.py tests/test_budget.py tests/test_token_budget.py
• tests/test_api_docs.py / changelog fragments

[Birfy]

PASS

Tip e5fdb32eead3771e2417358e4222d0d03c926f3b — sync/async two contracts (#809). Stacked on #816. risk_gate likely T3 (evolution.py). Bridge fails closed without max_seconds+max_rollouts; prefer async_evolve. Ready for Danyang merge click after #816 lands and CI is green.

[Birfy]

Verdict: PASS

Tip SHA: e5fdb32
Ran: read PR body + tip commit git show vs parent (19 files / #809-focused); full PR-vs-base diff (stacked); linked #809; local pytest -q tests/test_sync_async_contracts.py tests/test_budget.py tests/test_provider_and_split_contracts.py (28 passed); risk_gate.py → T3
Not run: full matrix CI on this box (waiting on GitHub Actions build + test 3.9–3.13)

Summary

Closes #809 acceptance cleanly: evolve(asynchronous=True) is an honest deprecated bridge — fails closed without explicit max_seconds and max_rollouts (no invented 20s, no rounds×n_workers reinterpretation), emits FutureWarning, and forwards to async_evolve. One _POLICY_DRIVER_SUPPORT table + drift test (executor sync-only). Spec plan names max_rollouts at plan time when missing. Docs (async.md, evolution.md, api.md) and callers/tests updated consistently; BudgetSettings covered on both drivers.

Notes

• Tip commit itself is scoped to evolve: sync and async paths are two contracts behind one evolve() entry #809; PR is stacked on fix(evolve): Budget/Runtime/Observability settings bags #816 (base: fix/804-policies-consolidation). Merge fix(evolve): Budget/Runtime/Observability settings bags #816 first, then retarget this PR to main before landing.
• risk_gate T3 (evolution.py + stacked SKILL/integration paths) — needs Danyang click; never auto-merge.
• Prior tip comment was informal PASS (not Verdict:); this is the formal new-PR review for this tip.

nit (non-blocking)

• docs/evolution.md recipe PipelineParallel is a no-op under evolve(): WorkUnit.stage is never read, so PP degenerates into redundant DP #2 (async_evolve(..., max_seconds=1200) without max_iters) is fine for the direct API; keep that distinction clear vs the bridge which requires both budgets.

[Birfy]

Follow-up after required CI on tip e5fdb32eead3771e2417358e4222d0d03c926f3b:

Required checks red — build green; test (3.9)–test (3.13) all FAILURE.

Root cause: callers still using the deprecated bridge without max_rollouts= (and sometimes relying on rounds reinterpretation):

• tests/test_bench.py — test_staleness_is_measured_on_both_paths, test_the_lag_budget_is_what_made_the_async_row_look_broken, test_a_run_that_discards_most_of_its_evidence_says_so
• tests/test_fault_matrix.py — all [async] parametrized cases (rounds=12 → ValueError asking for max_rollouts)

Please extend the same migration already done for test_budget / test_async_evolve / test_worker_resilience (pass explicit max_rollouts= or call async_evolve directly), then push a new tip for re-review.

risk_gate remains T3; stacked on #816 — still needs merge #816 → retarget to main → Danyang click after green.

[Birfy]

Verdict: PASS

Tip SHA: b840cc1
Ran: patched bench/run.py workload + tests/test_fault_matrix.py async engine to pass explicit max_rollouts= (rounds×workers) for the #809 bridge; pytest -q on the three previously-red test_bench cases + full tests/test_fault_matrix.py (25 passed); pytest -q tests/test_sync_async_contracts.py tests/test_provider_and_split_contracts.py (18 passed); risk_gate.py expected T3 (evolution.py already on PR)
Not run: full GitHub Actions matrix on this tip (build + test 3.9–3.13 still queued after push)

Summary

CI on e5fdb32e failed because evolve(asynchronous=True) now fails closed without max_rollouts. Callers still relied on the old rounds reinterpretation:

• bench/run.py workload(): async configs now set max_rollouts = rounds * n_workers (equal-budget with the sync matrix).
• tests/test_fault_matrix.py async engine: max_rollouts=36 (12×3).

Contract unchanged; tests/callers aligned with #809/#817. Stacked on #816; still T3 — do not squash-merge until Danyang clicks after #816 lands and this tip's CI is green.