Repository navigation
fix(cli): name the resolved config file in the no-provider panel - #2010
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Scope boundary: the "No Provider Configured" panel printed by
opensquilla agentnames the config file the CLI actually reads instead of the literal~/.opensquilla/config.toml.Non-goals: no change to config resolution, provider detection, onboarding or the gateway.
Branch
Base branch: main
Target exception: N/A
Issue
Linked issue: Fixes #1990
Cause:
_print_no_provider_error()insrc/opensquilla/cli/agent_cmd.pyhard-coded~/.opensquilla/config.tomlin the "Cause" paragraph and in "Option 3". The CLI reads a different file whenOPENSQUILLA_STATE_DIR,OPENSQUILLA_GATEWAY_CONFIG_PATHor a profile home is in effect, so following the panel edited a file the command never loads and the same panel came back; the "has no [llm].api_key" sentence could also be false for the file it named.Fix: the panel now prints the path returned by
onboarding.config_store.resolve_config_path, the resolver that mirrorsGatewayConfig.load, fed withOPENSQUILLA_GATEWAY_CONFIG_PATHexactly likerun_agent_oncedoes. Default setups keep printing~/.opensquilla/config.toml.Release Note
Release note:
opensquilla agentwithout a provider now names the config file it actually reads (state dir, profile or explicit path) in the "No Provider Configured" panel.Tests
Ruff:
ruff checkandruff format --checkclean on the two changed files.Pytest: two new cases in
tests/test_agent_cmd_no_key.pyrunagent -m hiwith a temporaryOPENSQUILLA_STATE_DIRand withOPENSQUILLA_GATEWAY_CONFIG_PATHand check the panel names that file and no longer the literal~/.opensquilla/config.toml. Both fail onmainand pass with the change; the file's four existing cases still pass (6 passed). Only this test file was run, not the full suite.Build: not affected (CLI text only).
This change was prepared with the assistance of an AI coding agent (Claude).