Repository navigation
Merged
Conversation
…s literal is a defect The T14 session for the ramp issue's new exit (Linux, ToyOS at 4f52c30, Linux) ran clean, but ToyOS's osbench_lan refused its group: "no netstack link holds 10.0.2.15". std's TcpStream::local_addr answers QEMU's user network address whatever the lease is, and since #1122 osbench names a connection's link by that address. The ramp issue records the void session and the Linux runs' per-connection spread: 478 KB at 100 ms, sixteen times the parity boot's miss, with the two runs exchangeable (p = 0.69, 0.42). The getsockname finding becomes a defect and names std's copy of the literal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The T14 session that #1138 staged ran Linux, ToyOS at 4f52c30, then Linux, and every run exited 0. It decides nothing: ToyOS's
osbench_lanfound the peer, then refused the whole group withno netstack link holds 10.0.2.15.The cause is on main, not in [tcp]:
TcpStream::socket_addr(sdk/std/sys/net/connection.rs) returns a hard-coded10.0.2.15with the stream's local port. libc'sgetsocknamedoes the same.sys::link_ofpicks a connection's link by matching that address against netstack's leases.Change (issues only)
getsockname-answers-an-address-nobody-asked-netstack-for: changes from finding to defect, with this evidence. It names std's copy of the literal and the fix: netstack's connect and accept answers carry the local address, and the SDK, std and libc return it.Checks
Issue text only. No IP shape outside RFC 1918.
Evidence: https://github.com/ToyOSOrg/evidence/tree/35f09268e09714a8547496bdd766bcd3ca998325/r1
Risk
osbench_lan's whole group refuses on every network that doesn't lease 10.0.2.15, so no LAN row is measurable on metal.🤖 Generated with Claude Code