Repository navigation
GitHub Actions: document DISABLED_TESTS and count the dogfood plugins - #195
Merged
Merged
Conversation
… instead of hard-coding them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #191.
What
validateaction. Test names contain spaces, so they can't go in the whitespace-splitargsinput;DISABLED_TESTSon the step'senvworks (comma-separated names, or an absolute path to a file listing them). Uses "Discrete parameter state restoration" as the example, since Add a discrete parameter state restoration test and fix false failures in the existing one #191 makes it fail at strictness 8+ for plugins usingjuce::AudioParameterBool, and the README's own example is at strictness 10.acceptance.yml: the fixtures step now counts the dogfood plugin bundles and passes both the glob and the count on, so the validate check compares against the actual number instead of a hard-coded4. Adding a test plugin no longer needs a workflow edit. The check also fails if no plugins are found.Testing
validateaction script locally withDISABLED_TESTS="Plugin state,Audio processing": the report dropped from 17 to 15 test cases, with both named tests gone.