Repository navigation
Enable contracted funnel events in Kingston site.json - #16
Merged
Merged
Conversation
Add resource_open and install_prompt show/dismiss payloads, accepted by Lighthouse 1.35.0 as plain daily totals with no labels. Amend disclosure with one sentence covering listing-open counts and prompt shows/dismissals. Update the Kingston contract test to pin the nine-event wire format. Authorized by Jay 2026-10-08.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enables the three contracted funnel signals for Kingston, per Jay's explicit go-ahead (2026-10-08). Two files changed:
deployments/kingston/site.json— adds threeevent_payloadsentries and one disclosure sentence:tests/unit/kingston-analytics.test.ts— the Kingston contract test now pins the nine-event wire format (was six), asserting exact payloads, keys, and that the three new signals carry no attribution labels.Contract alignment
resource_openandinstall_promptshow/dismiss as plain daily totals — no labels, no visit token, no listing identity.attribution.events; they stay unattributed per the contract.visit_linkage(flag no longer exists), no schema changes, no other deployments touched.Verification
assertSitevalidation passes on the edited config.Deployment note
Merging does not deploy by itself. Kingston goes live with these events only when
release/kingstonis advanced to the merge commit (npm run release -- --site deployments/kingston --ref <merge-sha> --publish) — Jay's call after review.