Repository navigation
Add unattributed Kingston product signals and KFH report 1.3 (1.35.0) - #9
Merged
Merged
Conversation
Accept two fixed v3 signals from the existing Kingston origins: resource_open and install_prompt show/dismiss, with no labels, visit token or extra fields. Store them in additive migration 0018 (kfh_signal_daily) outside the core batch, prune them separately, and emit report 1.3 whose product_signals section fails independently of the core report. Existing events, tables and retention are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XjWi12Wph4pkB7QjvpjKX4
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XjWi12Wph4pkB7QjvpjKX4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: Lighthouse drops Kingston
resource_openandinstall_promptshow/dismiss events. It still answers 204, but nothing is counted, and the/kfhreport has no product-signal section.After: Lighthouse counts listing-detail opens, install-prompt shows and install-prompt dismissals as daily, unattributed totals in a new
kfh_signal_dailytable. The KFH report moves to contract 1.3 with aproduct_signalssection. Existing events, tables, retention and the core report are unchanged.If the new table is missing or broken, only
product_signalsreports "unavailable". Core counts, outreach and retention keep working.How:
parseKfhSignalaccepts only v3 payloads with the exact base keys, so avisittoken or any extra field is still rejected. Each signal is upserted outside the core batch, the new table is pruned in its own try/catch, and the report falls back to signals-unavailable if validation fails. The sharedkfhSignalsContract.tsand the fixtures are byte-identical to Agent Smith 0.31.0 (#13, already merged and deployed). The release-control test now pins version 1.35.0.Rollout (in order)
kfh_outreach_daily) is applied in production.kfh_signal_daily, additive).Rollback: Redeploy 1.34.1. The 0018 table can stay, because nothing else reads it. Smith accepts 1.0 to 1.3.
Checks: typecheck and 221/221 tests (
npm test) pass locally.