Skip to content

fix(math): fmtCompact promotes the suffix when rounding reaches 1000 #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hey-research-lab wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −5
Open

fix(math): fmtCompact promotes the suffix when rounding reaches 1000 #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions app/src/lib/launchpad/math.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,18 @@ test("unavailable figures use — without turning them into zero", () => {
assert.equal(fmtUsd(0), "$0");
});

test("fmtCompact promotes the suffix when rounding reaches 1000 of a unit", () => {
assert.equal(fmtCompact(1_234), "1.23K");
assert.equal(fmtCompact(999_000), "999.00K");
assert.equal(fmtCompact(999_999), "1.00M", "no 1000.00K");
assert.equal(fmtCompact(-999_999), "-1.00M");
assert.equal(fmtCompact(999_996_000), "1.00B", "no 1000.00M");
assert.equal(fmtCompact(999_960, 1), "1.0M", "no 1000.0K");
assert.equal(fmtCompact(1_500_000_000_000), "1.50T");
assert.equal(fmtUsd(999_960, { compact: true }), "$1.0M");
assert.equal(fmtCompact(42.5), "42.50");
});

test("fmtEth trims noise", () => {
assert.equal(fmtEth(10n ** 18n), "1");
assert.equal(fmtEth(5n * 10n ** 16n), "0.05");
Expand Down
16 changes: 11 additions & 5 deletions app/src/lib/launchpad/math.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,14 +121,20 @@ export function minOut(amountOut: bigint, slippageBps: number): bigint {

// ── formatting ───────────────────────────────────────────────────────────────

const COMPACT_UNITS: readonly [number, string][] = [[1e12, "T"], [1e9, "B"], [1e6, "M"], [1e3, "K"]];

/** Compact number with a K/M/B/T suffix. A value that rounds up to 1000 of a unit takes the next one: 999,999 → "1.00M", never "1000.00K". */
export function fmtCompact(n: number, digits = 2): string {
if (!Number.isFinite(n)) return "—";
const abs = Math.abs(n);
if (abs >= 1e12) return `${(n / 1e12).toFixed(digits)}T`;
if (abs >= 1e9) return `${(n / 1e9).toFixed(digits)}B`;
if (abs >= 1e6) return `${(n / 1e6).toFixed(digits)}M`;
if (abs >= 1e3) return `${(n / 1e3).toFixed(digits)}K`;
return n.toFixed(abs >= 100 ? 0 : abs >= 1 ? 2 : digits);
const i = COMPACT_UNITS.findIndex(([size]) => abs >= size);
if (i === -1) return n.toFixed(abs >= 100 ? 0 : abs >= 1 ? 2 : digits);
const [size, suffix] = COMPACT_UNITS[i];
if (i > 0 && Math.abs(Number((n / size).toFixed(digits))) >= 1000) {
const [nextSize, nextSuffix] = COMPACT_UNITS[i - 1];
return `${(n / nextSize).toFixed(digits)}${nextSuffix}`;
}
return `${(n / size).toFixed(digits)}${suffix}`;
}

/** Quote amount for display: "0.0421" style, trimming noise. bigint = wei (18 dec); number = whole units. */
Expand Down
Loading