Repository navigation
CR-3 acceptance re-run on main: populated journey captures and evidence (#322) - #464
Merged
Merged
Conversation
…rd CR-3 acceptance re-run (#322) The journey spec's synthetic world served no files for field-guide #91 and no check runs for lending #73's head, so its R1 capture showed "Checks · not found" and its R4 capture an empty Changes pane and file tree. The reference comparison (#322 Step 3) needs populated panes, so the world now carries four files for #91 (+11 −4) and four check runs plus one commit status for #73. Geometry assertions are unchanged. Records the 2026-10-30 re-run on main f51ef7e: focused Code Review specs 24/24, Step 1 unit files 75/75, full build/typecheck/unit/e2e green, and the read-only authenticated navigation probe 6/6. Points the VoiceOver checklist at the landed build. The R1–R4 comparison still waits for Val's references and the human keyboard/VoiceOver result. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
14 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumes CR-3 acceptance for #322 on
mainatf51ef7e. No product code changes.What changed
e2e/code-review-journey.spec.ts: the synthetic world now serves four files for field-guide feat: add Claude CLI sign-in and verified account status #91 (+11 −4) and four check runs plus one commit status for lending composer: restore typed text when thread:send fails #73's head. Before this, the R1 capture read "Checks · not found" and the R4 capture showed "0 of 4 files loaded" with an empty file tree (the 2026-10-28 captures were the same), so a reference comparison would have measured empty panes. Geometry assertions are unchanged; the populated R4 geometry is still inbox 53–333, PR pane 333–996, diff 997–1470, tree 1470–1760.docs/reviews/2026-10-30-cr3-acceptance-resume.md: the re-run on currentmain, the authenticated probe, the capture gap and the remaining gates.docs/reviews/2026-10-22-cr8-voiceover/checklist.md: names the landed build (afec85bor later).docs/status.mdand the design page's Workspace evidence paragraph.Evidence on
mainf51ef7e(worktreecr3-resume, this Mac)pnpm install --frozen-lockfile && pnpm buildcode-review-navigation,-ipc,-scroll,-regressionsspecspnpm typecheckpnpm testpnpm test:e2eA-main, account BunsDev, gh 2.102.0)code-review-journey.spec.tsafter the fixture changeThe full E2E run preceded the journey fixture change; the journey spec was re-run alone afterwards, and no product code changed. Evidence outside the repository:
~/Documents/Codex/artifacts/modex-cr3-acceptance/2026-10-30/.Still open on #322 (Val's)
ui:comparecommand are ready once a reference directory is named.Do not merge without Val's go-ahead. Issue #322 remains open for its recorded human acceptance gates.
🤖 Generated with Claude Code