Repository navigation
Refuse known cloud-routed and non-generative local models in main (#380) - #465
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 of 13 tasks
Step 3: discovery marked Ollama's cloud-forwarded models and embedding models unselectable, but only in the renderer's list. LocalModelDiscovery's per-model record now keeps that reason, and LocalExecution.validate refuses such a model before spawning; on an Ollama connection a :cloud/-cloud name is refused even unlisted. Unmarked models stay unverified. Regressions in the execution and discovery suites; disabling each of the four guards in the compiled output made its regression fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BunsDev
force-pushed
the
lm5-cloud-models
branch
from
October 31, 2026 05:08
37cf2c6 to
73f1683
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LM-5 (#380), step 3: main refuses known cloud-routed and non-generative local models. This is stacked on #462 and will be rebased onto
mainonce #462 merges.mainstill doesn't constructLocalExecution.What changes
Discovery already marked Ollama's cloud-forwarded models and embedding models unselectable, but only in the list the renderer shows. Main now refuses them itself.
LocalModelDiscovery's per-model record (from Keep a local context window's sources apart and refuse one above the advertised maximum (#380) #462) also keepsunselectable:cloud,embeddingorother.LocalExecution.validaterefuses these before any process starts:…:cloud/…-cloudname, even if it was never listed;An unmarked model stays unverified rather than local.
Tests
validateand by the turn, with nothing spawned.Disabling each of the four guards in the compiled output made its regression fail:
Both passed again after a byte-for-byte restore.
pnpm build && pnpm test(head37cf2c6)No UI changes.
Docs:
docs/local-models.md,docs/status.mdand the review record.🤖 Generated with Claude Code