Skip to content

Fix Claude pool credential isolation, redaction and retry cooldown - #469

Merged
BunsDev merged 1 commit into
claude-accountsfrom
claude-pool-repair
Nov 1, 2026
Merged

BunsDev merged 1 commit into
claude-accountsfrom
claude-pool-repair

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Repairs three review findings in #467: inherited credentials could override a selected Claude profile, gateway keys could reach streamed transcript observations before final-result redaction, and a second usage-limited account remained eligible for the next conversation.

Profile turns, health checks and login now remove conflicting inherited credentials and endpoints consistently. Gateway message and reasoning streams redact the key before journal/IPC delivery, including split events; a secret-bearing tool request receives a fixed denial without displaying the raw action or approving a sanitized substitute. The one permitted retry records its account’s cooldown without starting a third attempt.

This branch is based on claude-accounts and leaves the original author’s branch untouched. The upstream AGENTS.md records Val’s OrcaRouter destination approval. Live second-subscription, real-limit and OrcaRouter acceptance remain unrun; all credentials and processes in the added tests are synthetic.

Validation: failing-first regressions recorded for all three findings; latest focused account/login run 27 passed; independent repair review found no blockers. pnpm build and pnpm test passed (2,298 passes across the workspace, 26 skips); the account Electron E2E test passed (1/1, 10.8 seconds). The earlier overlapping diagnostic run is preserved separately, including its three security failures and module-load failure.

@vercel

vercel Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Nov 1, 2026 12:12pm UTC

Request Review

@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

claude-accounts 32f1cb4 claude-pool-repair de1b2e7 +/-
66% 66% 0%
View coverage of the 10 most impacted files.
File claude-accounts 32f1cb4 claude-pool-repair de1b2e7 +/-
apps/desktop/sr...ngine/runner.ts 98% 98% 0%
apps/store-desk...rc/main/demo.ts 95% 95% 0%
apps/desktop/sr...kends/claude.ts 98% 98% 0%
apps/desktop/sr...claude-login.ts 100% 100% 0%
apps/desktop/sr...gine/secrets.ts 100% 100% 0%
apps/desktop/sr...udeAccounts.tsx 0% 0% 0%
apps/desktop/sr...ain/commands.ts 87% 88% +1%
apps/desktop/sr...count-claude.ts 0% 87% +87%
apps/desktop/sr...-secret-sink.ts 0% 95% +95%
apps/desktop/sr...ude-accounts.ts 0% 99% +99%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

@BunsDev
BunsDev merged commit 82fe8fd into claude-accounts Nov 1, 2026
6 checks passed
@BunsDev
BunsDev deleted the claude-pool-repair branch November 1, 2026 12:48
BunsDev added a commit that referenced this pull request Nov 1, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
Preview — de1b2e7e Deployed Nov 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant