Repository navigation
Correct Code Review acceptance gates and token evidence checks - #478
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs the remaining review findings in #472. AC2 now stays partial for the unimplemented C58 attachment and C59 reasoning-effort controls, and their decisions are included in the enablement gates. The failed local E2E run remains distinct from its isolated retry and the earlier hosted pass.
The CR-6 and CR-7 procedures now use a shared token scanner that returns incomplete on authentication or evidence errors instead of reporting a false clean result. It prints status only. CR-6 also distinguishes no matching write from a failed trace scan. No live credential, provider call, or app GitHub write was used.
Validation: nine synthetic regressions passed, covering clean evidence, nested token matches, failed authentication, empty token, missing evidence, symlinks, unreadable files, missing gh, and absent path inputs.
pnpm build && pnpm testpassed with 2,277 passes and 26 skips. Independent review found no blockers. Application source is unchanged; the existing human and named-repository gates remain open.This is stacked on
cr-gates-lane-cat245be00b2976e0c58b7fe036515feb2206a2160band includes main's already merged October 31 date corrections. Evidence:docs/reviews/2026-11-01-cr-gate-corrections.md.