Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 1, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add real Electron behavioral coverage for two open CR-8 controls: the opening activity row (C50) and the bot comment menu’s Copy comment link (C51). The test asserts actor, wording and timestamp, then uses keyboard activation and verifies the exact clipboard IPC URL, copied status, menu closure and focus return. Clipboard handling is intercepted inside the fixture; no system clipboard write or live GitHub mutation is performed.
Validation: build and full unit suite passed (2,277 passes, 26 skips). Full E2E passed on its first run: 479 desktop passes, 7 skips, and 7 site passes. Cold transcript median was 93.4 ms against the unchanged 500 ms gate. Separate built-renderer negative controls for incorrect opening text and incorrect comment URL each failed the intended assertion; the restored test passed. Independent review found no blockers.
This is fixture/Electron evidence. Programmatic focus proves keyboard activation and focus return, not Tab reachability. Reference comparison and VoiceOver remain open. Refs #327; this does not complete its full acceptance matrix.
Hosted validation also passed for head
52c58eabc1c8bd472ebfd121fa4ce93da73cfa78: all checks succeeded, including macOS job124890065569in run41320699362(482 desktop E2E passes, 4 skips; 7 site passes). Protected merge-queue validation and the actual merge remain separate steps.Main has since advanced through #477, #476 and #483 to
66d00318fe08d701067102033b1b9a741ac151ec. This branch now conflicts with the repository-rename regression and status changes. A repair preserving both tests has been prepared and checked for clean application to that main revision, but is not committed or validated in Electron. The passing checks above belong to the existing PR head; merge-queue admission must wait for the conflict repair and fresh required checks.