Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Nov 3, 2026
Contributor
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds four Electron regressions for existing remote diff controls: wrap/highlight rendering and per-file horizontal scrolling, keyboard/pointer divider resizing with reload persistence and reset, file-menu copy-path IPC and GitHub link destination, and revision-bound context requests. No application behavior changes. Related: #324, #327.
Validation: build and full unit suite passed (2,277 passes, 26 skips). The full E2E retry passed 482 desktop cases with 7 skips, followed by 7 site cases. Four focused tests passed, four temporary negative controls failed as expected, and independent code/evidence review found no blocking findings.
The first full run had 481 desktop passes, 7 skips and one existing Canvas full-view failure; its site stage did not run. The failure trace and all 107 result files are archived with SHA-256 verification. Three instrumented Canvas repetitions and five unchanged repetitions passed, followed by the unchanged full retry. The original cause remains unestablished; this PR does not claim a Canvas fix. The receipt also retains the initial divider-test navigation error and wrapping negative-control diagnostic.
Clipboard IPC is intercepted, external navigation is not performed, and programmatic focus does not prove Tab reachability or VoiceOver acceptance. Original-reference comparison, authenticated behavior and human acceptance remain open. See
docs/reviews/2026-11-01-cr5-diff-controls.mdfor environment, fixture, commands and limitations.Hosted validation passed for head
0feda81cf39d7f93fc1279721563cfcb077794a3: all 12 checks succeeded. macOS job124906967944passed 485 desktop E2E cases with 4 skips, followed by 7 site cases. This is branch validation; protected merge-queue validation and the actual merge are still pending.Current main
7cfb29c7b0bfa452c9285f9b85a63a704cda857fnow conflicts with this branch indocs/status.md. A patch preserving the original tests and receipt while retaining all current-main status entries has been prepared and checked for clean application in a disposable index. It is not committed or runtime-validated. Queue admission must wait for the integrated revision and fresh required checks; the hosted results above remain evidence for the earlier PR head.