Repository navigation
feat: add routing OG card, sharing checks and developer guide - #7
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The OG route lacks the required Edge runtime, and several sharing/source-contract checks need stronger assertions or CI integration.
Review effort: Lite
Findings: 1
Open (5)
What changed in this PR
Adds OG/Twitter sharing metadata, a 1200×630 PNG renderer, sharing checks, and developer discovery documentation.
Changes:
- Adds generated social-card rendering and metadata.
- Adds Playwright and source-contract validation.
- Adds architecture/privacy guidance,
llms.txt, and SVG artwork.
| File | Summary | Final review notes |
|---|---|---|
scripts/social-metadata.test.mjs |
Source-contract validation | Moderate (2 votes): include this check in CI or the normal test command. |
llms.txt |
Project navigation and guidance | No findings. |
e2e/sharing.spec.ts |
Metadata, PNG, and screenshot checks | Moderate (2 votes): wait for Demo mode; moderate (3 votes): assert the configured origin; moderate (2 votes): assert no /api/route request. |
docs/discovery/README.md |
Developer, architecture, privacy, and sharing guide | No findings. |
docs/discovery/assets/social-preview.svg |
Editorial sharing artwork | No findings. |
app/opengraph-image.tsx |
Generated social image renderer | Critical (1 vote): export runtime = "edge". |
app/layout.tsx |
OG/Twitter metadata configuration | No findings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Completed sharing slice
Verification and conversations
Latest exact-head CI for
e1912fe00ebfc7dd8d72620dd3993c7cc9d90085passed in run36264841238: source guard, unit tests, types, lint, production build and browser suite.Artifact
10914340261was downloaded and matched SHA-256ddf846040bd58d20db515e07a4c557312e363bdbf826f5cf1768f4ed9401d4d1. Generated PNG and both screenshots were visually inspected. Provenance records the tested merge commit, verified no-key demo and zero classification attempts; the configuration GET is intentionally allowed.All five review threads were addressed and resolved. The Edge-only premise was checked against official documentation and actual successful Node-runtime PNG generation; no unnecessary runtime switch was made. The renderer accepts no request/user/provider input.
Publication boundaries
No application routing policy, credentials, dependencies, license or visibility changed. Artwork is not a screenshot, and test captures are not production captures. GitHub About/topics and repository Social preview settings remain separate authorized settings operations, not effects of committing this PR.