Repository navigation
Conversation
Documentation build overview
No files changed. |
3ca17e1 to
5a84524
Compare
RyanM-RMA
changed the title
| required = true), | ||
| queryParams = { | ||
| @OpenApiParam(name = OVERRIDE_PROTECTION, type = Boolean.class, | ||
| description = "Create will fail if provided Gate Changes already exist." + |
There was a problem hiding this comment.
Description has not been changed, look at override protection annotations from other controllers for reference.
There was a problem hiding this comment.
Updated the description to be in alignment with other OVERRIDE_PROTECTION descriptions. Also updated FAIL_IF_EXISTS description.
| " Default: true"), | ||
| @OpenApiParam(name = FAIL_IF_EXISTS, type = Boolean.class, | ||
| description = "Create will fail if provided Gate Changes already exist. Default: true") | ||
| description = "Create will fail if provided Gate Changes already exist." + |
There was a problem hiding this comment.
There is a deprecated boolean that should be set for this OpenApiParam annotation
There was a problem hiding this comment.
Added the deprecated flag for FAIL_IF_EXISTS
| .body(json) | ||
| .header(AUTH_HEADER, USER.toHeaderValue()) | ||
| .queryParam(FAIL_IF_EXISTS, "false") | ||
| .queryParam(OVERRIDE_PROTECTION, "false") |
There was a problem hiding this comment.
Perhaps include a test to verify the old query parameter can still be used for the time being
…added deprecated flag for FAIL_IF_EXISTS.
This branch has not been deployed
2 participants
Summary
Switched FAIL_IF_EXISTS to OVERRIDE_PROTECTION for gate change post endpoint. Updated unit tests
Related Issue
Closes #1906
Jira Ticket: https://jira.hecdev.net/browse/CDA-142
Validation
Verified with unit tests
Checklist