fix(voice): let the in-flight tool drain outlast a single tool call [JAR-10169] - #1867
Draft
JoshParkSJ wants to merge 3 commits into
Draft
fix(voice): let the in-flight tool drain outlast a single tool call [JAR-10169]#1867JoshParkSJ wants to merge 3 commits into
JoshParkSJ wants to merge 3 commits into
Conversation
The drain after a voice session ends was capped at 30s while a voice tool call can now run up to 180s (JAR-10169), so any call ending mid-tool always abandoned the in-flight task. Raise the cap to 190s, just above the tool deadline, so the tool reaches its own timeout and reports instead of being dropped here. Trade-off: a URT job can now linger up to ~3 minutes after the caller hangs up if a Process tool is still running. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
test:uipath-langchain
2.14.6 is already published, so check-version-availability fails the PR and the drain fix never reaches uipath-agents-python. 2.14.7 also stays inside that repo's uipath>=2.14.4,<2.15.0 range, so a lock refresh picks it up. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The lint job runs `uv sync --locked --all-extras`, which refuses to re-lock, so pyproject at 2.14.7 against a lock still pinning 2.14.6 failed CI. Also drop the ticket reference from the drain comment; the constant's relationship to the tool-call deadline is the part worth keeping in the code. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
🚨 Heads up:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of 3 for JAR-10169. Companions: uipath-agents-python#695 (the substantive fix), AgentInterfaces#1163.
Problem
_INFLIGHT_TOOL_DRAIN_AFTER_AGENT_END_TIMEOUT_SECONDSwas 30s. Once a voice tool call can run up to 180s (#695), a drain shorter than a single tool call means any session ending mid-tool abandons the in-flight task — the tool never reaches its own timeout, so it never reports.This was already latent at 60s; raising the tool ceiling to 180s makes it certain.
Change
30s → 190s, just above the tool-call deadline, so the tool hits its own timeout and reports rather than being dropped here.
Trade-off worth flagging: a URT job can now linger up to ~3 minutes after the caller hangs up if a Process tool is still running. That is the cost of allowing 3-minute tools; the alternative is silently dropping results for work Orchestrator is still executing. Cancelling the task would not cancel the Orchestrator job anyway.
Verification
15 passedinpackages/uipath/tests/cli/chat/test_voice_bridge.py; ruff check and format clean.No new test here — the change is a single constant whose effect is a wall-clock cap on a drain, and the meaningful regression coverage lives with the deadline logic in #695.
🤖 Generated with Claude Code