Skip to content

fix(cli): preserve legacy Windows launcher path - #2172

Closed
mynameistito wants to merge 1 commit into
UsefulSoftwareCo:mainfrom
mynameistito:fix/2171-windows-powershell-cli-shim
Closed

mynameistito wants to merge 1 commit into
UsefulSoftwareCo:mainfrom
mynameistito:fix/2171-windows-powershell-cli-shim

Conversation

@mynameistito

@mynameistito mynameistito commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Keep bin/executor as a compatibility launcher in generated and preview CLI packages while declaring bin.mjs for new installs. This lets stale Windows PowerShell shims continue to work after an upgrade.

Linked issue

Fixes #2171

Verification

  • bun run format:check — passed locally and in CI.
  • bun run lint — passed locally and in CI.
  • Typecheck — CI passed. The local Windows run reports existing signal-listener typing errors in apps/cli and apps/local.
  • Tests — CI passed. The local full-suite run is blocked by missing better-sqlite3 bindings and a FumaDB temp-cleanup EPERM.
  • Windows wrapper smoke — generated a preview package and ran both bin.mjs and the legacy bin/executor through Node.
  • CI run — format, lint, typecheck, tests, and all E2E shards passed.

Checklist

  • Added a changeset (bun run changeset), or this change needs none.
  • Added or updated tests for the new behaviour.
  • No secrets, credentials, or private data in the diff.

@mynameistito
mynameistito marked this pull request as ready for review October 2, 2026 09:28
@mynameistito
mynameistito marked this pull request as draft October 2, 2026 09:30
@RhysSullivan

Copy link
Copy Markdown
Collaborator

Thanks for tracking this down and for the fix, @mynameistito. You were right that the stale shim still points at v1's bin/executor. A local upgrade inside Bun's global directory reproduces it: the package changes, but ~/.bun/bin/executor still targets the old path.

This repository is a snapshot of the v2 source and doesn't take pull requests. We're landing your approach, with credit to you, in the private v2 source. The v2 launcher will keep declaring bin.mjs and will also ship bin/executor as a forward to it, so shims from v1 and from the betas both work. It will ship in a coming 2.0.0 beta. Closing this one in favor of that.

Sent from my Claude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v2] Windows PowerShell CLI resolves the removed v1 bin path

2 participants