fix(cli): preserve legacy Windows launcher path - #2172
Closed
mynameistito wants to merge 1 commit into
Closed
mynameistito wants to merge 1 commit into
mynameistito wants to merge 1 commit into
Conversation
mynameistito
marked this pull request as ready for review
October 2, 2026 09:28
mynameistito
marked this pull request as draft
October 2, 2026 09:30
Collaborator
|
Thanks for tracking this down and for the fix, @mynameistito. You were right that the stale shim still points at v1's This repository is a snapshot of the v2 source and doesn't take pull requests. We're landing your approach, with credit to you, in the private v2 source. The v2 launcher will keep declaring Sent from my Claude |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep
bin/executoras a compatibility launcher in generated and preview CLI packages while declaringbin.mjsfor new installs. This lets stale Windows PowerShell shims continue to work after an upgrade.Linked issue
Fixes #2171
Verification
bun run format:check— passed locally and in CI.bun run lint— passed locally and in CI.apps/cliandapps/local.better-sqlite3bindings and a FumaDB temp-cleanupEPERM.bin.mjsand the legacybin/executorthrough Node.Checklist
bun run changeset), or this change needs none.