feat: add trainee self reflection API (T-313) - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add configurable trainee self-reflection to training records. Seed a
training-self-reflectionsheet with one free-text field, expose its active fields, and return submitted answers with the existing training DTO.The trainee or a user with
controller-training-director-assistantpermission can save or edit the reflection at any time. Reading follows existing training-record permissions, including other mentors. The sheet endpoint is scoped to the training ID and uses the same visibility check; training DTOs return reflection answers without additional filtering. Existing role inheritance applies. Saves reuse the sheet filing in a transaction with a training-row lock, including concurrent first submissions.Validation
Deployment
Apply
20260921000000_add_training_self_reflection.sqlbefore deploying the API and the companion frontend change. Staff can configure the sheet through the existing sheet management system.Implements T-313. Mentor feedback revision history (T-314) is outside this change.
Companion frontend: VATPRChina/vatprc-docs#84.