docs(roadmap): note luacheck has no enforcement anywhere

[FullGas1]

Logs a roadmap idea found while verifying develop post-merge (PR #129): CLAUDE.md claims luacheck is enforced via CI when not installed locally, but grepping .github/workflows/ shows zero jobs actually run it, and the local luacheck-on-edit.sh PostToolUse hook no-ops silently when the binary is missing. No code has been checked by real luacheck for an unknown amount of time. No functional change, label skip-changelog.

Summary by Sourcery

Document the missing luacheck quality gate and track its restoration as a future roadmap effort.

Enhancements:

• Document the absence of effective luacheck enforcement in local development and CI, and record options for adding visible or blocking lint validation.

Documentation:

• Add a roadmap item noting that luacheck is not currently run by CI or reliably by the local edit hook, and outlining potential remediation approaches.

[sourcery-ai]

Reviewer's Guide

Adds a roadmap entry documenting the gap between the stated luacheck quality guarantee and its actual absence from CI and local enforcement, and outlines possible remediation and rollout options.

File-Level Changes

Change	Details	Files
Documents a roadmap item identifying that luacheck is currently not enforced locally or in CI.	Records that CI contains no luacheck job and that the existing Lua check only validates syntax with luac5.1. Explains that the local PostToolUse hook silently skips checks when luacheck is unavailable. Proposes adding a CI job, making the local hook visible or blocking, or both, with a decision on gating versus report-only rollout deferred.	dev/roadmap.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 1 issue

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="dev/roadmap.md" line_range="203-216" />
<code_context>
+## luacheck n'est en réalité vérifié nulle part (ni local, ni CI)
</code_context>
<issue_to_address>
**nitpick:** The heading and conclusion state that luacheck is verified nowhere, but the local hook does run luacheck whenever the executable is installed; the documented problem is missing CI enforcement and a silent local no-op on machines without the binary, not universal absence of local checking.

**Triggers:** When a developer or future implementer reads this roadmap item outside the Windows environment described.

**Suggested fix:** Narrow the wording to say that effective enforcement is absent in CI and unavailable on this machine, while the local hook remains best-effort when luacheck is installed.

```suggestion
## luacheck n'est effectivement imposé ni en CI, ni sur cette machine

Constaté en vérifiant l'état de `develop` après le merge de `FEAT-TROOP-ZONE-SCRIPTED-API` (PR
#129, 2026-08-26) : `CLAUDE.md` affirme "`luacheck --config .luacheckrc src/` must be clean (rely
on CI if not installed locally)", mais **aucun job CI n'exécute luacheck** (grep confirmé sur
`.github/workflows/` — zéro occurrence). Le job `Lua 5.1 Syntax Check` ne fait qu'un `luac5.1 -p`
(compilation/syntaxe), pas d'analyse statique (variables inutilisées, globals implicites, etc.).

Côté local, le hook `tools/hooks/luacheck-on-edit.sh` (PostToolUse sur Edit/Write d'un fichier
`src/*.lua`) exécute luacheck lorsqu'il est installé, mais devient un **no-op silencieux** quand
`luacheck` n'est pas installé (`command -v luacheck` échoue) — le cas sur cette machine Windows
(absent du PATH et de `luarocks/rocks/bin`). Résultat : le code fusionné dans cette même PR
(`src/CTLD_zone.lua`) n'a jamais été passé au luacheck réel sur cette machine (hook muet), ni en CI
(job absent) — la garantie de qualité annoncée dans `CLAUDE.md` n'est effectivement assurée ni en
CI, ni sur cette machine.
```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

nitpick: The heading and conclusion state that luacheck is verified nowhere, but the local hook does run luacheck whenever the executable is installed; the documented problem is missing CI enforcement and a silent local no-op on machines without the binary, not universal absence of local checking.

Triggers: When a developer or future implementer reads this roadmap item outside the Windows environment described.

Suggested fix: Narrow the wording to say that effective enforcement is absent in CI and unavailable on this machine, while the local hook remains best-effort when luacheck is installed.

Suggested change

	## luacheck n'est en réalité vérifié nulle part (ni local, ni CI)
	Constaté en vérifiant l'état de `develop` après le merge de `FEAT-TROOP-ZONE-SCRIPTED-API` (PR
	#129, 2026-08-26) : `CLAUDE.md` affirme "`luacheck --config .luacheckrc src/` must be clean (rely
	on CI if not installed locally)", mais **aucun job CI n'exécute luacheck** (grep confirmé sur
	`.github/workflows/` — zéro occurrence). Le job `Lua 5.1 Syntax Check` ne fait qu'un `luac5.1 -p`
	(compilation/syntaxe), pas d'analyse statique (variables inutilisées, globals implicites, etc.).
	Côté local, le hook `tools/hooks/luacheck-on-edit.sh` (PostToolUse sur Edit/Write d'un fichier
	`src/*.lua`) est un **no-op silencieux** quand `luacheck` n'est pas installé (`command -v
	luacheck` échoue) — le cas sur cette machine Windows (absent du PATH et de
	`luarocks/rocks/bin`). Résultat : le code fusionné dans cette même PR (`src/CTLD_zone.lua`) n'a
	jamais été passé au luacheck réel, ni pendant la session (hook muet), ni en CI (job absent) — la
	garantie de qualité annoncée dans `CLAUDE.md` est un filet vide depuis on ne sait combien de temps.
	## luacheck n'est effectivement imposé ni en CI, ni sur cette machine
	Constaté en vérifiant l'état de `develop` après le merge de `FEAT-TROOP-ZONE-SCRIPTED-API` (PR
	#129, 2026-08-26) : `CLAUDE.md` affirme "`luacheck --config .luacheckrc src/` must be clean (rely
	on CI if not installed locally)", mais **aucun job CI n'exécute luacheck** (grep confirmé sur
	`.github/workflows/` — zéro occurrence). Le job `Lua 5.1 Syntax Check` ne fait qu'un `luac5.1 -p`
	(compilation/syntaxe), pas d'analyse statique (variables inutilisées, globals implicites, etc.).
	Côté local, le hook `tools/hooks/luacheck-on-edit.sh` (PostToolUse sur Edit/Write d'un fichier
	`src/*.lua`) exécute luacheck lorsqu'il est installé, mais devient un **no-op silencieux** quand
	`luacheck` n'est pas installé (`command -v luacheck` échoue) — le cas sur cette machine Windows
	(absent du PATH et de `luarocks/rocks/bin`). Résultat : le code fusionné dans cette même PR
	(`src/CTLD_zone.lua`) n'a jamais été passé au luacheck réel sur cette machine (hook muet), ni en CI
	(job absent) — la garantie de qualité annoncée dans `CLAUDE.md` n'est effectivement assurée ni en
	CI, ni sur cette machine.