feat: add ICNS write support regarding to issue 203 - #226
Closed
DenizSAHIN570 wants to merge 1 commit into
Closed
Conversation
Enable encoding images to Apple ICNS format using a custom PNG-based encoder targeting modern OS X 10.5+ icon types (ic07-ic14). Resized PNG variants are cached by pixel size to avoid duplicate work.
Author
|
@JovannMC Sorry to tag directly but it's been few months. Was curious if you have plans to merge this feature or if it's something not needed atm. |
Member
hiya! firstly sorry for the late response to your PR (if it has been open for a while). we are closing this, along with other people's PRs, as we are preparing for the very overdue update drop. once merged, it will most likely break most existing PRs and will need to be redone. track the PR #282, and once merged you may wish to open another PR with the new base. do also note this repository's and our main contributing guidelines which was made recently here, when submitting your new PR: repo & main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable encoding images to Apple ICNS format using a custom PNG-based encoder targeting modern OS X 10.5+ icon types (ic07-ic14). Resized PNG variants are cached by pixel size to avoid duplicate work.
Let me know if anything isn't up to projects standard.