perf: use lossless ZIP compression for TIFF output - #279
Closed
yeagoo wants to merge 2 commits into
Closed
Conversation
Member
hiya! firstly sorry for the late response to your PR (if it has been open for a while). we are closing this, along with other people's PRs, as we are preparing for the very overdue update drop. once merged, it will most likely break most existing PRs and will need to be redone. track the PR #282, and once merged you may wish to open another PR with the new base. do also note this repository's and our main contributing guidelines which was made recently here, when submitting your new PR: repo & main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TIFF output currently inherits the input compression state, so common conversions can produce uncompressed files or reuse a JPEG compression choice. Set the writer's
settings.compressionto ZIP for both.tiffand.tif.This is an output-policy/performance change: it trades additional compression time for smaller losslessly encoded TIFF files. It should be reviewed separately from pixel-correctness fixes. It does not promise every input will get smaller.
Validation
JPEG, BMP and PNG fixtures are converted to both TIFF extensions. The decoded compression must be ZIP and pixels must equal the decoded input, avoiding another lossy JPEG encode. A deliberately compressible fixture also verifies that output is smaller than the raw RGB buffer.
bun run test: 11 passed, including five shared behavior tests.bun run build: passed with a local.envbased on.env.example.bun run check: the same 7 pre-existing missing Node type errors as upstream; no additional errors. Full-repository lint has existing failures outside this change; changed files pass.Patch structure
This branch is based on upstream
cc7b5a54d5e9c797b377db47b9bdfbb561707783and includes shared test harness commitc69e961, which moves the existingmagickConvertfunction unchanged into a utility imported by the worker. Tests invoke that exact production function with the installed WASM. No new package dependency is introduced.Each repair branch can be reviewed independently. After the shared harness lands, the remaining branches will need rebasing onto upstream main to resolve overlapping edits in
magick-convert.ts.Shares the behavior-preserving test harness with #275.