Skip to content

Retain explicitly provided falsy custom transports#3097

Merged
adamtheturtle merged 4 commits into
mainfrom
adamtheturtle/issue-3092-falsy-transport
Jul 17, 2026
Merged

Retain explicitly provided falsy custom transports#3097
adamtheturtle merged 4 commits into
mainfrom
adamtheturtle/issue-3092-falsy-transport

Conversation

@adamtheturtle

Copy link
Copy Markdown
Member

Summary

  • Fixes all six clients so only None selects the default transport (transport if transport is not None else ...).
  • Prevents falsy but valid custom transports from being silently replaced.
  • Adds sync and async tests covering every affected client constructor.

Closes #3092.

Test plan

  • pytest tests/test_transports.py::test_falsy_*
  • CI green on this PR

Made with Cursor

Only None should select the default transport across all sync and
async clients. Closes #3092.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@adamtheturtle
adamtheturtle merged commit 6b24ea1 into main Jul 17, 2026
16 checks passed
@adamtheturtle
adamtheturtle deleted the adamtheturtle/issue-3092-falsy-transport branch July 17, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Falsy custom transports are silently replaced by default transports

1 participant