Conversation
* The RM3 example was modified to include an external force defined by the user
akeeste
left a comment
akeeste
left a comment
There was a problem hiding this comment.
Initial review comments attached. Changes for whoever can next pick this up to start with
There was a problem hiding this comment.
If only position output is visualized, pare down file size
There was a problem hiding this comment.
If only position output is visualized, pare down file size
There was a problem hiding this comment.
If only position output is visualized, pare down file size
There was a problem hiding this comment.
resave to older simulink version
| %Plot waves | ||
| waves.plotElevation(simu.rampTime); | ||
| try | ||
| waves.plotSpectrum(); | ||
| catch | ||
| end | ||
|
|
||
| %Plot heave response for body 1 | ||
| output.plotResponse(1,3); | ||
|
|
||
| %Plot heave response for body 2 | ||
| output.plotResponse(2,3); | ||
|
|
||
| %Plot heave forces for body 1 | ||
| output.plotForces(1,3); | ||
|
|
||
| %Plot heave forces for body 2 | ||
| output.plotForces(2,3); | ||
|
|
||
| %Save waves and response as video | ||
| % output.saveViz(simu,body,waves,... | ||
| % 'timesPerFrame',5,'axisLimits',[-150 150 -150 150 -50 20],... | ||
| % 'startEndTime',[100 125]); |
There was a problem hiding this comment.
pare down to visualizations specific to this case. Maybe combine with dataVisualization.m?
|
@basaucier some more additions to this PR that just came to mind:
See some of the other applications (e.g. Generalized_Body_Modes) for sample files that you can adapt here. It would be great if the test file also confirmed how an identical force can be applied at different points, e.g. as:
|
|
Added the requested The The test file verifies that the example runs, checks that
The added test passes locally with 3 passed, 0 failed. |
|
@akeeste TODO |
akeeste
left a comment
akeeste
left a comment
There was a problem hiding this comment.
- Consolidate the visualization files.
dataVisualization.mandPlotResults.mare duplicative but don't explain what is being shown. - Save simulink file to 2020b so that I can review it
- The test file is not actually testing the simulink model at all. It runs the wecSimInputFile.m once and defines it's own function that is tested.
The simulink model should:
- read a 6dof translation vector and 6dof force from the input file
- do any translation necessary
The test should then:
- run the simulink example for multiple force-vector combinations
- verify the force is being applied correctly
I would also like to understand where the force is being applied in the model by default, but need the correct simulink version to do so
3 participants
The RM3 example was modified to include an external force defined by the user