Skip to content

Fix CI tests - #115

Merged
akeeste merged 13 commits into
WEC-Sim:mainfrom
akeeste:fix_tests
Sep 30, 2026
Merged

akeeste merged 13 commits into
WEC-Sim:mainfrom
akeeste:fix_tests

Conversation

@akeeste

@akeeste akeeste commented Jul 8, 2026 •

Copy link
Copy Markdown
Contributor

This PR addresses test failures called out #114 (comment):

  • Mooring/MooringMatrix - failing on windows due to the accelerator build needing a compiler on the CI
  • OWC - license check out failing on ubuntu when PR based (ubuntu when push based and both windows pass...)
    • this passed on a rerun. May be an inconsistent issue or was resolved in some other dependency
  • Paraview/OSWEC - failing on windows due to the accelerator build needing a compiler on the CI
  • VariableHydro/variableMass - failing due to the model file sphereVarMass being in R2025a(?)

@akeeste

akeeste commented Jul 8, 2026 •

Copy link
Copy Markdown
Contributor Author

A few references on adding the MinGW compiler to actions:

@akeeste

akeeste commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

A couple notes after looking into this more in the two matlab pages linked above:
MinGW 14.2 is supported as of R2026a
MinGW-w64 version 8.1 for R2023a and later
MinGW-w64 version 6.3 for R2018b and later
MinGW-w64 version 5.3 for R2017b through R2018a
MinGW-w64 version 4.9.2 for R2015b through R2017a

I will need to adjust the version and double check that the install location is correct

@jtgrasb
jtgrasb self-requested a review September 28, 2026 16:54
@jtgrasb

jtgrasb commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

I did some additional testing and was able to update the testing script to allow MATLAB to see the MinGW source after installing. I removed the changes to the input files, so it's not testing it here, but the successful tests can be found here.

I also saved the two variable hydro case Simulink files as R2023b, and this fixed the error we were seeing on the CI for those.

I believe this should resolve all of the CI errors.

@akeeste akeeste left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for wrapping this up @jtgrasb ! This solution is pretty slick--searching for the executable itself on that instance of the VM vs trying to figure out where Actions installs it and hardcoding the path in. Tests are passing. merging!

@akeeste
akeeste changed the base branch from dev to main September 30, 2026 19:48
@akeeste

akeeste commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

*Changed to go into main. I'll merge this and then pull main into dev

@akeeste
akeeste merged commit d53d4d4 into WEC-Sim:main Sep 30, 2026
3 checks passed
@akeeste akeeste mentioned this pull request Sep 30, 2026
@akeeste
akeeste deleted the fix_tests branch October 1, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants