Repository navigation
Bump tinacms to 3.14.0 and @tinacms/app to 2.5.14 (GHSA-x34j-47hf-4xg7) [SECURITY] - #275
Open
superbot-helper wants to merge 1 commit into
Open
superbot-helper wants to merge 1 commit into
superbot-helper wants to merge 1 commit into
Conversation
GHSA-x34j-47hf-4xg7: the admin preview frame trusted its own parent rather than the admin origin, so a page that framed the admin could drive its preview navigation. 3.14.0 resolves the preview path against the expected origin and refuses an off-origin parent. The deployed admin bundle is what carries this: it is built from this lock and served under /admin on the site.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package-lock.jsonresolvestinacms@3.11.0and@tinacms/app@2.5.10, both inside this advisory's ranges. The build runstinacms buildintopublic/admin, CI deploysout/to thewxyc.org/*Worker, and the admin is served athttps://wxyc.org/admin/— so this is the app's own shipped surface, not a library in the abstract. This moves both packages to their first patched versions. Nopackage.jsonchange:^3.9.3(dependencies) admits 3.14.0, and@tinacms/cli's^2.5.10for the app admits 2.5.14.tinacms <= 3.13.0,@tinacms/app <= 2.5.133.14.0,2.5.14The fix commit's
preview-url.test.tsit.eachtable, lifted verbatim and run per case: the 3.11.0 arm is its shippedPreviewInnersplat-to-url statements plusgetExpectedPreviewOrigin; the 3.14.0 arm is the shippedresolvePreviewPathplusgetPreviewOrigin. "Frames" is where the iframe loaded; "anchor" is the origin the admin then trusted./other.example/, rejected//other.example/, rejected\\other.example/, rejected/\other.example/, rejected\t//other.example/, rejected//other.example/admin/, rejected..//other.example/, rejected../..//other.example/, rejecteda/..//other.example/, rejected.//other.example/, rejected10/10 activate on 3.11.0; 0/10 on 3.14.0. The six non-
it.eachcases (ordinary path, query+fragment, empty, undefined, absolute URL, no origin) stay same-origin on both arms.Limits
App-level, measured in Node, not in a browser. The admin bundle is deployed, so an editor who opens
https://wxyc.org/admin/#/~//other.example/preaches the vulnerable path; what is measured here is the frame URL and the trust anchor, not the postMessage round-trip against a live TinaCloud token. The admin was built with dummy credentials and--skip-cloud-checks. The app's own suite was run as 8 named files on both arms (149 passed, 1 skipped); there is no typecheck script. The lock move is 166 entries because tinacms 3.14.0's tree differs; it is not a minimal diff.