[zoom plugin] no mouse follow - #3121
Open
vdegenne wants to merge 1 commit into
Open
Conversation
Member
|
This code looks a lot more complicated than I'd expect for this feature. The way I see it, you should be able to install an activator binding which toggles a boolean and records the cursor position. Then, if the boolean is set, use the saved cursor position instead of the actual cursor position. Bonus points to add a transformer that smooth-moves from saved cursor position to actual cursor position when the keybinding is toggled 'off'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I leave that here in case you want to help me collaborate.
It's just a plain implementation of no mouse follow for the native zoom plugin.
The main issue left is mouse events are not properly scaling with the zoom factor.
should implement #3027
note: Also
no followshould be a toggle flag, it's on the todo-list.