Repository navigation
feat: show section schedules on the course Dates tab - #26
Merged
Merged
Conversation
| * A week runs Monday through Sunday. "This week" is the rest of the current | ||
| * week after today, and "next week" is the following Monday through Sunday. | ||
| */ | ||
| fun classifyCalendarDay(date: Date, today: Date = Date()): DatesSection { |
| fun sundayOfWeek(day: Date): Date { | ||
| val calendar = Calendar.getInstance() | ||
| calendar.time = day.clearTime() | ||
| val daysUntilSunday = (Calendar.SUNDAY - calendar.get(Calendar.DAY_OF_WEEK) + 7) % 7 |
| fun sundayOfWeek(day: Date): Date { | ||
| val calendar = Calendar.getInstance() | ||
| calendar.time = day.clearTime() | ||
| val daysUntilSunday = (Calendar.SUNDAY - calendar.get(Calendar.DAY_OF_WEEK) + 7) % 7 |
| * | ||
| * These values are wall-clock dates, so they are not parsed as UTC instants. | ||
| */ | ||
| fun parseWallDate(isoDate: String): Date? { |
| */ | ||
| fun parseWallDate(isoDate: String): Date? { | ||
| val parts = isoDate.split("-") | ||
| if (parts.size != 3) { |
| val minute = parts.getOrNull(1)?.padStart(2, '0') ?: "00" | ||
| val suffix = if (hour < 12) "am" else "pm" | ||
| val hour12 = when (hour) { | ||
| 0, 12 -> 12 |
| val minute = parts.getOrNull(1)?.padStart(2, '0') ?: "00" | ||
| val suffix = if (hour < 12) "am" else "pm" | ||
| val hour12 = when (hour) { | ||
| 0, 12 -> 12 |
| val suffix = if (hour < 12) "am" else "pm" | ||
| val hour12 = when (hour) { | ||
| 0, 12 -> 12 | ||
| in 13..23 -> hour - 12 |
| val suffix = if (hour < 12) "am" else "pm" | ||
| val hour12 = when (hour) { | ||
| 0, 12 -> 12 | ||
| in 13..23 -> hour - 12 |
| val suffix = if (hour < 12) "am" else "pm" | ||
| val hour12 = when (hour) { | ||
| 0, 12 -> 12 | ||
| in 13..23 -> hour - 12 |
yogeshbhagatcode
requested changes
Oct 14, 2026
yogeshbhagatcode
left a comment
Collaborator
There was a problem hiding this comment.
@choeying-10 There are lots of github-security comments. Can you please look into them and see if we have any issue?
Author
they are only Detekt code-style warnings about return counts and unnamed numbers, not security or functional issues. |
yogeshbhagatcode
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/course-schedule/v1/{course_id}/separately from the existing course dates API, and show them as cards on the Dates tab.