Repository navigation
Keep onboarding opt-in and validate issue 128 acceptance - #208
Merged
Merged
Conversation
WilhelmZA
marked this pull request as ready for review
November 1, 2026 00:30
WilhelmZA
force-pushed
the
fix/onboard-128-acceptance
branch
from
November 1, 2026 00:45
7bdcb97 to
e4f1efb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review remediation
Follow-up to merged PR #205. Refs #128; the issue remains open for reviewer acceptance.
structured_outputis absent.structured.enable_for_bgp_routeandstructured.enable_for_tracerouteseparately from device opt-in.Validation
git diff --check: passed.onboard checkreports reviewed against configuration files and model defaults: all 4 structured-instance findings and 26 text-instance findings confirmed.lab-ioll2intentionally uses text on both instances. Both device files explicitly setstructured_output: false;lab/tests/test_lab.pyalso requires text for this device.Keep #128 open until the reviewer accepts the live evidence.