Repository navigation
Conversation
Seven tests in internal/events/gate_test.go: the idle tick must cost one statement and open no transaction; processOne must not claim for consumers the gate did not name; an active consumer with no handler in this process must still be scanned, because deliveries must exist for a handler registered later. Three existing engine tests must call tick before processOne, because a worker now claims only for consumers the gate named. The counting helper also never incremented the write counter, so the budget assertion could not pass. Run green against the gated core checkout: ok windshift/internal/events 3.489s, rc=0 (golang:1.27.2-alpine).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclosure
I am Gnarl, the Operator's agent. This PR is opened in his name, on account
Faks, at hisinstruction. It was written with AI assistance, which CONTRIBUTING permits, and I am stating that
plainly instead of letting it read as human work. I understand every line below and can explain it.
The numbers are measured, not assumed.
Prepared by Gnarl, the Operator's agent. The commit is authored and committed under account
Faks,at his instruction, because the CLA check resolves the commit author email to a GitHub account and
the agent email is not linked to one. I have not signed the CLA; that is his act to perform.
What
Two files.
internal/events/gate_test.go— seven tests for the idle-tick gate:processOneclaims nothing when the gate reported no work,MAX(id)read, and the cursoradvances from the gate's max id,
exist for a handler registered later,
ANY(), noFOR UPDATE, plain placeholders),internal/events/store_test.go— three existing engine tests must calltickbeforeprocessOne, because a worker now claims only for consumers the gate named. Asserted behavior isunchanged. The counting helper also never incremented the write counter, so the budget assertion
could not pass; that is fixed here.
Dependency, stated plainly
These tests pass only against a core checkout carrying
core PR #360. Against upstream core
main,processOneclaims for every consumer, so the three adjusted tests fail here. The adjustments are aconsequence of the gate, not a preference. If the core change is rejected, these test changes should
be rejected with it.
Measured run
Against the v0.8.9 line the same suite gives
ok windshift/internal/events 3.061s, rc=0.Not run
make lint.main.goembedsall:frontend/dist, which is not built here, so locally thelinter is restricted to
./internal/...: 0 issues, rc=0 on the gated checkout. CI is the real gate.mainwithout the code change, for the reason stated above.