Repository navigation
fix(api): retry safe requests rejected by the per-user concurrency limit - #339
Merged
stefan-ernst merged 1 commit intoOct 14, 2026
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
The per-user concurrency limiter answers request bursts with 429 Too Many Requests and Retry-After: 1. The API client surfaced that as a hard failure, so views that fan out many reads at once broke intermittently: on collection boards the item detail fallback (which now hydrates six reference lists in parallel) failed with "Too many concurrent requests" instead of rendering, and pickers loaded empty. Retry GET/HEAD/OPTIONS up to twice on 429, honouring Retry-After (capped at 5s, jittered), and stop waiting when the caller aborts. Writes are never retried. In-flight GET de-duplication keeps sharing a single retried request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dpb97
force-pushed
the
fix/api-retry-concurrency-limit
branch
from
October 14, 2026 06:39
a00854d to
78cb299
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #338
The per-user concurrency limiter answers bursts with
429+Retry-After: 1, but the API client surfaced that as a hard failure. On collection boards this broke the item detail fallback (six parallel reference reads viaPromise.all, see f9752b0) and left pickers empty.Change
performFetchWithRetry()wrapsperformFetchAPI()infetchFromAPI():429Retry-After(seconds) when present, otherwise 500 ms · 2^attempt; capped at 5 s, plus up to 250 ms jitter so parallel requests spread outAbortSignalfires (keeps superseded loaders cheap)createApiError()now recordsretryAfterfrom the response header.Tests
frontend/src/lib/api/core.spec.js(Vitest): retry then success, give up after the bound and surface the 429, no retry for PATCH, abort while waiting, delay calculation.Full suite locally: 92/93 – the remaining failure (
i18n-utils.spec.js > uses the active application locale, timeout) also fails on unmodifiedmainon my machine.biome checkclean for both files.Notes
I have read and agree to the CLA.
🤖 Generated with Claude Code