fix(ci): run uniffi-bindgen from the Rust workspace in the Windows wheel script - #246
Merged
Conversation
…eel script uniffi-bindgen invokes cargo metadata from the current directory. The bash wheel scripts happen to run it from inside ffi/rust (via cd), but the PowerShell script Pop-Locations back to the repo root — which has no Cargo.toml — before generating bindings, so the first real Windows CI run failed with 'could not find Cargo.toml'. The other three matrix legs built and checked green in the same run (33760245735). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First real run of the Windows wheel leg (dispatch 33760245735,
publish=testpypi) failed in step 3/6:uniffi-bindgenrunscargo metadatafrom the current directory. Both bash wheel scripts invoke it from insideffi/rust(macOS viacd $RUST_DIR, manylinux inside the container at/io/rust), but the PowerShell scriptPop-Locations back to the repo root — noCargo.tomlthere — before generating bindings. Fix: wrap the bindgen call inPush-Location $RustDir/Pop-Location, preserving the exit code across the pop.The same dispatch validated the rest of the pipeline: linux-x86_64, linux-aarch64 (first run), and macOS universal2 all built, install/import/version-checked, and Publish was correctly skipped on the matrix failure. Re-dispatching
publish=testpypiafter this lands exercises the full four-leg matrix again.🤖 Generated with Claude Code