fix(spawn-docker-jdk): treat cancelled JSON stream reads as expected termination - #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonNodeInputStreamProcessor.processreads NDJSON lines from a Docker response body and previously treated every exception thrown while reading as a genuine failure, logging a telemetry warning and callingsubscriber.onError. When a caller cancels a long-running stream (e.g. system events) viaResponse#cancel(), the underlying channel is closed while a read is blocked, which surfaces as aClosedChannelExceptionor itsAsynchronousCloseExceptionsubtype.This is now caught separately from the generic
Throwablehandler and treated as an expected termination rather than a failure: no telemetry warning is recorded andsubscriber.onErroris not invoked, since the stream simply ends via the normalfinallyblock instead.This was verified by temporarily commenting out the new catch block and re-running
SessionTests, which reproduced the spuriousFailed while processing the JSON input streamwarnings withAsynchronousCloseException/ClosedChannelExceptioncauses on every cancellation, confirming the new catch clause targets the exception actually thrown byUnixSocketHttpTransport'sSocketChannel-backed body stream.