Conversation
kuznetsss
commented
Sep 11, 2026
| // shared with the guest: append only, never renumber, never negative — a verdict and a | ||
| // `HostFunctionError` share one `i32`, split by sign. The second declaration of | ||
| // `xrpl_host_functions::FloatOrdering`, which links into the guest and so cannot use `cxx`. | ||
| enum class FloatOrdering : int32_t { |
Contributor
Author
There was a problem hiding this comment.
This enum duplicates the same one from host functions crate. I'll remove that duplication later by generating a c++ header file in host functions crate.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
kuznetsss
changed the title
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
|
All conflicts have been resolved. Assigned reviewers can now start or resume their review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Apply the XLS fix: XRPLF/XRPL-Standards#627
The implementation was already correct but the comment was outdated.
Expressed return value of
floar_compare()as an enum and refactored the way enums are added in host functions crate to avoid duplication.Context of Change
The new enum was the third macro defining
ALLandcode()/from_code()in the same way. Rewrote it to macro annotation to avoid duplication.API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)